Skip to content

Conversation

@bdehamer
Copy link
Contributor

@bdehamer bdehamer commented Oct 7, 2025

Closes #492

Bumps the release predicate from v0.1 to v0.2 in order to rename the releaseId predicate field to packageId.

Rendered version

Signed-off-by: Brian DeHamer <[email protected]>
@bdehamer bdehamer requested a review from a team as a code owner October 7, 2025 13:49
Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bdehamer ! The spec changes LGTM, but can you please also update the corresponding .proto file under protos/ ? No need to regenerate the language bindings, since that's handled by the CI.

@bdehamer bdehamer force-pushed the release-predicate-v02 branch from 8b2c223 to 1e96a19 Compare October 8, 2025 14:43
@bdehamer
Copy link
Contributor Author

bdehamer commented Oct 8, 2025

@marcelamelara I noticed that the previous release proto was in release/v0 (and use similarly named v0 package names in the proto def itself). I'm assuming that we do NOT want to just update the proto in-place, so i added a new release/v0.2 directory.

Lemme know if this is not the correct approach.

@bdehamer bdehamer requested a review from marcelamelara October 8, 2025 14:46
@marcelamelara
Copy link
Contributor

@bdehamer Thanks for adding that. Yes, given that this isn't a backwards compatible change, creating a separate v0.2 directory. Does it make sense to rename the current release/v0 directory to release/v0.1? We did this for another predicate when we had a similar situation, but I don't know how many implementations depend on the current directory.

@bdehamer
Copy link
Contributor Author

Updated!

Copy link
Contributor

@marcelamelara marcelamelara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @bdehamer !

@marcelamelara marcelamelara requested a review from a team October 11, 2025 01:37
@TomHennen TomHennen merged commit 59a7636 into in-toto:main Oct 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider renaming releaseId in release attestation

3 participants