Skip to content

Conversation

@Zabriskije
Copy link
Contributor

When params.footer.enable is set to false, it causes a phantom scroll effect (more visible on pages with little content). Here's a preview:

footerfalse

The problem is --menu-height: 3.75rem, but just setting it to --menu-height: 3.8rem fixes the issue.

@netlify
Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for hugo-hextra ready!

Name Link
🔨 Latest commit f757a2f
🔍 Latest deploy log https://app.netlify.com/sites/hugo-hextra/deploys/67f6ef703523b50008526e1c
😎 Deploy Preview https://deploy-preview-658--hugo-hextra.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Zabriskije Zabriskije changed the title Phantom scroll fix when params.footer.enable is set to false fix: phantom scroll when params.footer.enable is set to false Apr 4, 2025
@imfing
Copy link
Owner

imfing commented Apr 7, 2025

let me look into this, this might actually be a small bug

@imfing
Copy link
Owner

imfing commented Apr 9, 2025

turns out the sidebar bottom menu container was calculated to 61 pixels in the browser, while 3.75rem is 60 pixels. so the total height of sidebar exceeds the view height by 1 pixel

i updated your PR to put a limit to the sidebar bottom container.

Copy link
Owner

@imfing imfing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for spotting this.

@imfing imfing merged commit 1cc02a6 into imfing:main Apr 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants