Remove unreachable code to fix go vet (go-yaml#249)

mogthesprog · im-kulikov · commit f5bbce5ed91d · 2018-01-05T15:55:57.000+03:00
diff --git a/decode.go b/decode.go
@@ -137,7 +137,6 @@ func (p *parser) parse() *node {
 	default:
 		panic("attempted to parse unknown event: " + strconv.Itoa(int(p.event.typ)))
 	}
-	panic("unreachable")
 }
 
 func (p *parser) node(kind int) *node {
diff --git a/emitterc.go b/emitterc.go
@@ -666,7 +666,6 @@ func yaml_emitter_emit_node(emitter *yaml_emitter_t, event *yaml_event_t,
 		return yaml_emitter_set_emitter_error(emitter,
 			"expected SCALAR, SEQUENCE-START, MAPPING-START, or ALIAS")
 	}
-	return false
 }
 
 // Expect ALIAS.
diff --git a/parserc.go b/parserc.go
@@ -166,7 +166,6 @@ func yaml_parser_state_machine(parser *yaml_parser_t, event *yaml_event_t) bool
 	default:
 		panic("invalid parser state")
 	}
-	return false
 }
 
 // Parse the production:

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,6 @@ func (p parser) parse() node {`
`137`	`137`	`default:`
`138`	`138`	`panic("attempted to parse unknown event: " + strconv.Itoa(int(p.event.typ)))`
`139`	`139`	`}`
`140`		`- panic("unreachable")`
`141`	`140`	`}`
`142`	`141`
`143`	`142`	`func (p parser) node(kind int) node {`
Original file line number	Diff line number	Diff line change
`@@ -666,7 +666,6 @@ func yaml_emitter_emit_node(emitter yaml_emitter_t, event yaml_event_t,`
`666`	`666`	`return yaml_emitter_set_emitter_error(emitter,`
`667`	`667`	`"expected SCALAR, SEQUENCE-START, MAPPING-START, or ALIAS")`
`668`	`668`	`}`
`669`		`- return false`
`670`	`669`	`}`
`671`	`670`
`672`	`671`	`// Expect ALIAS.`
Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,6 @@ func yaml_parser_state_machine(parser yaml_parser_t, event yaml_event_t) bool`
`166`	`166`	`default:`
`167`	`167`	`panic("invalid parser state")`
`168`	`168`	`}`
`169`		`- return false`
`170`	`169`	`}`
`171`	`170`
`172`	`171`	`// Parse the production:`