From d2377247695db8c406b5bc83b909025918d0a09b Mon Sep 17 00:00:00 2001 From: Stefan Topfstedt Date: Wed, 22 Oct 2025 15:32:18 -0700 Subject: [PATCH 1/5] linting fix - use assert.strictEqual over assert.equal --- .../components/new-learningmaterial-test.gjs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/test-app/tests/integration/components/new-learningmaterial-test.gjs b/packages/test-app/tests/integration/components/new-learningmaterial-test.gjs index ee5063ed26..d55dfd98af 100644 --- a/packages/test-app/tests/integration/components/new-learningmaterial-test.gjs +++ b/packages/test-app/tests/integration/components/new-learningmaterial-test.gjs @@ -112,9 +112,9 @@ module('Integration | Component | new learningmaterial', function (hooks) { , ); assert.notOk(component.copyrightPermission.errorMessage.isPresent); - assert.equal(component.copyrightPermission.ariaInvalid, 'false'); + assert.strictEqual(component.copyrightPermission.ariaInvalid, 'false'); assert.notOk(component.copyrightRationale.errorMessage.isPresent); - assert.equal(component.copyrightRationale.ariaInvalid, 'false'); + assert.strictEqual(component.copyrightRationale.ariaInvalid, 'false'); await component.save(); assert.strictEqual( @@ -125,16 +125,16 @@ module('Integration | Component | new learningmaterial', function (hooks) { component.copyrightPermission.errorMessage.text, 'Agreement or alternate rationale is required for upload', ); - assert.equal(component.copyrightPermission.ariaInvalid, 'true'); + assert.strictEqual(component.copyrightPermission.ariaInvalid, 'true'); assert.strictEqual( component.copyrightRationale.errorMessage.text, 'Copyright Rationale can not be blank', ); - assert.equal(component.copyrightRationale.ariaInvalid, 'true'); + assert.strictEqual(component.copyrightRationale.ariaInvalid, 'true'); await component.copyrightPermission.toggle(); assert.notOk(component.copyrightPermission.errorMessage.isPresent); - assert.equal(component.copyrightPermission.ariaInvalid, 'false'); + assert.strictEqual(component.copyrightPermission.ariaInvalid, 'false'); assert.notOk(component.copyrightRationale.isVisible); }); @@ -153,7 +153,7 @@ module('Integration | Component | new learningmaterial', function (hooks) { ); assert.notOk(component.copyrightPermission.errorMessage.isPresent); assert.notOk(component.copyrightRationale.errorMessage.isPresent); - assert.equal(component.copyrightRationale.ariaInvalid, 'false'); + assert.strictEqual(component.copyrightRationale.ariaInvalid, 'false'); await component.save(); assert.strictEqual( @@ -169,12 +169,12 @@ module('Integration | Component | new learningmaterial', function (hooks) { component.copyrightRationale.errorMessage.text, 'Copyright Rationale can not be blank', ); - assert.equal(component.copyrightRationale.ariaInvalid, 'true'); + assert.strictEqual(component.copyrightRationale.ariaInvalid, 'true'); await component.copyrightRationale.set('my rationale'); assert.notOk(component.copyrightPermission.errorMessage.isPresent); assert.notOk(component.copyrightRationale.errorMessage.isPresent); - assert.equal(component.copyrightRationale.ariaInvalid, 'false'); + assert.strictEqual(component.copyrightRationale.ariaInvalid, 'false'); }); test('validate original author', async function (assert) { From e3af4e935dec0dd21cd6e374b5313ae244989ea7 Mon Sep 17 00:00:00 2001 From: Stefan Topfstedt Date: Wed, 22 Oct 2025 15:43:28 -0700 Subject: [PATCH 2/5] linting fix - corrects duplicate test case name. --- .../components/school-vocabulary-term-manager-test.gjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/frontend/tests/integration/components/school-vocabulary-term-manager-test.gjs b/packages/frontend/tests/integration/components/school-vocabulary-term-manager-test.gjs index bbee295745..266bfdc34a 100644 --- a/packages/frontend/tests/integration/components/school-vocabulary-term-manager-test.gjs +++ b/packages/frontend/tests/integration/components/school-vocabulary-term-manager-test.gjs @@ -182,7 +182,7 @@ module('Integration | Component | school vocabulary term manager', function (hoo assert.strictEqual(this.server.db.terms[0].title, 'new title'); }); - test('change term title', async function (assert) { + test('cancel erm title changes', async function (assert) { assert.expect(2); const vocabulary = this.server.create('vocabulary'); From e28518fe01389a118a3d4d1908831b49b9e5ee05 Mon Sep 17 00:00:00 2001 From: Stefan Topfstedt Date: Wed, 22 Oct 2025 15:46:26 -0700 Subject: [PATCH 3/5] linting fix - rm nonsense assertion. --- .../integration/components/learner-group/new-multiple-test.gjs | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/frontend/tests/integration/components/learner-group/new-multiple-test.gjs b/packages/frontend/tests/integration/components/learner-group/new-multiple-test.gjs index 41546d18e5..c00876ae3f 100644 --- a/packages/frontend/tests/integration/components/learner-group/new-multiple-test.gjs +++ b/packages/frontend/tests/integration/components/learner-group/new-multiple-test.gjs @@ -13,7 +13,6 @@ module('Integration | Component | learner-group/new-multiple', function (hooks) await render( , ); - assert.strictEqual(component.numb); assert.ok(component.isVisible); await a11yAudit(this.element); }); From 8cad8ce1a46dcb713aeb0a8249dddd0cbe9e39da Mon Sep 17 00:00:00 2001 From: Stefan Topfstedt Date: Wed, 22 Oct 2025 16:19:44 -0700 Subject: [PATCH 4/5] linter fix - no early returns. please see https://github.com/qunitjs/eslint-plugin-qunit/blob/main/docs/rules/no-early-return.md for the linter error that this code was triggering. --- .../tests/acceptance/reports/subjects-test.js | 8 ++++++-- .../reports/subject/instructor-test.gjs | 16 ++++++++++++---- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/packages/frontend/tests/acceptance/reports/subjects-test.js b/packages/frontend/tests/acceptance/reports/subjects-test.js index 16cc50a95b..bbc2b847d1 100644 --- a/packages/frontend/tests/acceptance/reports/subjects-test.js +++ b/packages/frontend/tests/acceptance/reports/subjects-test.js @@ -608,29 +608,33 @@ module('Acceptance | Reports - Subject Reports', function (hooks) { return { id, firstName, middleName, lastName, displayName }; }); counter++; + let rhett; switch (counter) { case 1: assert.strictEqual( query, 'query { courses(schools: [1], academicYears: [2015]) { id, school { title } } }', ); - return { + rhett = { data: { courses: [{ id: 1 }, { id: 31 }], }, }; + break; case 2: assert.ok(query.includes('query { courses(ids: [1,31])')); - return { + rhett = { data: { courses: [ { sessions: [{ offerings: [{ instructors: users, instructorGroups: [] }] }] }, ], }, }; + break; default: assert.ok(false, 'too many queries'); } + return rhett; }); await page.subjects.list.table.reports[0].select(); assert.strictEqual(currentURL(), '/reports/subjects/3'); diff --git a/packages/frontend/tests/integration/components/reports/subject/instructor-test.gjs b/packages/frontend/tests/integration/components/reports/subject/instructor-test.gjs index 44dbc4c0a0..1cf9bb8f22 100644 --- a/packages/frontend/tests/integration/components/reports/subject/instructor-test.gjs +++ b/packages/frontend/tests/integration/components/reports/subject/instructor-test.gjs @@ -236,20 +236,22 @@ module('Integration | Component | reports/subject/instructor', function (hooks) const { query } = JSON.parse(requestBody); counter++; const { users } = responseData.data; + let rhett = null; switch (counter) { case 1: assert.strictEqual( query, 'query { courses(academicYears: [2005]) { id, school { title } } }', ); - return { + rhett = { data: { courses: [{ id: 1 }, { id: 31 }], }, }; + break; case 2: assert.ok(query.includes('query { courses(ids: [1,31])')); - return { + rhett = { data: { courses: [ { sessions: [{ offerings: [{ instructors: [users[1]], instructorGroups: [] }] }] }, @@ -265,9 +267,11 @@ module('Integration | Component | reports/subject/instructor', function (hooks) ], }, }; + break; default: assert.ok(false, 'too many queries'); } + return rhett; }); const { id } = this.server.create('report', { subject: 'instructor', @@ -326,6 +330,7 @@ module('Integration | Component | reports/subject/instructor', function (hooks) const { query } = JSON.parse(requestBody); counter++; const { users } = responseData.data; + let rhett; switch (counter) { case 1: assert.strictEqual( @@ -333,7 +338,7 @@ module('Integration | Component | reports/subject/instructor', function (hooks) 'query { courses(learningMaterials: [1]) { id, school { title } } }', 'correct first query is run', ); - return { + rhett = { data: { courses: [ { @@ -342,9 +347,10 @@ module('Integration | Component | reports/subject/instructor', function (hooks) ], }, }; + break; case 2: assert.ok(query.includes('query { courses(ids: [1])'), 'correct second query is run'); - return { + rhett = { data: { courses: [ { sessions: [{ offerings: [{ instructors: [users[1]], instructorGroups: [] }] }] }, @@ -360,9 +366,11 @@ module('Integration | Component | reports/subject/instructor', function (hooks) ], }, }; + break; default: assert.ok(false, 'too many queries'); } + return rhett; }); const { id } = this.server.create('report', { subject: 'instructor', From 11727bcf5b2ff043b65237b07992ae09c8b5910a Mon Sep 17 00:00:00 2001 From: Stefan Topfstedt Date: Thu, 23 Oct 2025 13:05:21 -0700 Subject: [PATCH 5/5] Update packages/frontend/tests/integration/components/school-vocabulary-term-manager-test.gjs Co-authored-by: Michael Chadwick --- .../components/school-vocabulary-term-manager-test.gjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/frontend/tests/integration/components/school-vocabulary-term-manager-test.gjs b/packages/frontend/tests/integration/components/school-vocabulary-term-manager-test.gjs index 266bfdc34a..64ea7cf519 100644 --- a/packages/frontend/tests/integration/components/school-vocabulary-term-manager-test.gjs +++ b/packages/frontend/tests/integration/components/school-vocabulary-term-manager-test.gjs @@ -182,7 +182,7 @@ module('Integration | Component | school vocabulary term manager', function (hoo assert.strictEqual(this.server.db.terms[0].title, 'new title'); }); - test('cancel erm title changes', async function (assert) { + test('cancel term title changes', async function (assert) { assert.expect(2); const vocabulary = this.server.create('vocabulary');