updated acceptance tests to check for '0' instead of warning icon

Author: michaelchadwick

packages/frontend/tests/acceptance/program/programyear-list-test.js

@@ -67,7 +67,6 @@ module('Acceptance | Program - ProgramYear List', function (hooks) {
     this.server.create('cohort', { programYear });
     await page.visit({ programId: this.program.id });
     assert.strictEqual(page.programYears.items[0].competencies.text, '5');
-    assert.notOk(page.programYears.items[0].competencies.hasWarning);
   });
 
   test('check objectives', async function (assert) {
@@ -76,7 +75,6 @@ module('Acceptance | Program - ProgramYear List', function (hooks) {
     this.server.create('cohort', { programYear });
     await page.visit({ programId: this.program.id });
     assert.strictEqual(page.programYears.items[0].objectives.text, '5');
-    assert.notOk(page.programYears.items[0].objectives.hasWarning);
   });
 
   test('check directors', async function (assert) {
@@ -87,7 +85,6 @@ module('Acceptance | Program - ProgramYear List', function (hooks) {
     this.server.create('cohort', { programYear });
     await page.visit({ programId: this.program.id });
     assert.strictEqual(page.programYears.items[0].directors.text, '5');
-    assert.notOk(page.programYears.items[0].directors.hasWarning);
   });
 
   test('check terms', async function (assert) {
@@ -104,19 +101,18 @@ module('Acceptance | Program - ProgramYear List', function (hooks) {
     this.server.create('cohort', { programYear });
     await page.visit({ programId: this.program.id });
     assert.strictEqual(page.programYears.items[0].terms.text, '5');
-    assert.notOk(page.programYears.items[0].terms.hasWarning);
   });
 
-  test('check warnings', async function (assert) {
+  test('check empty values', async function (assert) {
     const programYear = this.server.create('program-year', {
       program: this.program,
     });
     this.server.create('cohort', { programYear });
     await page.visit({ programId: this.program.id });
-    assert.ok(page.programYears.items[0].competencies.hasWarning);
-    assert.ok(page.programYears.items[0].objectives.hasWarning);
-    assert.ok(page.programYears.items[0].directors.hasWarning);
-    assert.ok(page.programYears.items[0].terms.hasWarning);
+    assert.strictEqual(page.programYears.items[0].competencies.text, '0');
+    assert.strictEqual(page.programYears.items[0].objectives.text, '0');
+    assert.strictEqual(page.programYears.items[0].directors.text, '0');
+    assert.strictEqual(page.programYears.items[0].terms.text, '0');
   });
 
   test('check link', async function (assert) {
@@ -162,10 +158,10 @@ module('Acceptance | Program - ProgramYear List', function (hooks) {
     await page.programYears.newProgramYear.done.click();
     assert.strictEqual(parseInt(page.programYears.items[0].link.text, 10), thisYear);
     assert.strictEqual(page.programYears.items[0].title, `Class of ${thisYear + 4}`);
-    assert.ok(page.programYears.items[0].competencies.hasWarning);
-    assert.ok(page.programYears.items[0].objectives.hasWarning);
-    assert.ok(page.programYears.items[0].directors.hasWarning);
-    assert.ok(page.programYears.items[0].terms.hasWarning);
+    assert.strictEqual(page.programYears.items[0].competencies.text, '0');
+    assert.strictEqual(page.programYears.items[0].objectives.text, '0');
+    assert.strictEqual(page.programYears.items[0].directors.text, '0');
+    assert.strictEqual(page.programYears.items[0].terms.text, '0');
   });
 
   test('can add a program-year (with pre-existing program-year)', async function (assert) {

packages/frontend/tests/pages/components/program-year/list-item.js

@@ -1,4 +1,4 @@
-import { clickable, create, isPresent, isVisible, text } from 'ember-cli-page-object';
+import { clickable, create, isVisible, text } from 'ember-cli-page-object';
 
 const definition = {
   scope: '[data-test-program-year-list-item]',
@@ -8,19 +8,15 @@ const definition = {
   title: text('[data-test-title]'),
   competencies: {
     scope: '[data-test-competencies]',
-    hasWarning: isPresent('[data-test-warning]'),
   },
   objectives: {
     scope: '[data-test-objectives]',
-    hasWarning: isPresent('[data-test-warning]'),
   },
   directors: {
     scope: '[data-test-directors]',
-    hasWarning: isPresent('[data-test-warning]'),
   },
   terms: {
     scope: '[data-test-terms]',
-    hasWarning: isPresent('[data-test-warning]'),
   },
   canBeRemoved: isVisible('[data-test-remove]'),
   remove: clickable('[data-test-remove]'),