Skip to content

Commit af9c233

Browse files
reduced space that timed release takes up but putting date/time on same line and not allowing to go full width in container
1 parent 4928ac5 commit af9c233

2 files changed

Lines changed: 85 additions & 76 deletions

File tree

packages/ilios-common/addon/components/learningmaterial-manager.gjs

Lines changed: 74 additions & 70 deletions
Original file line numberDiff line numberDiff line change
@@ -580,46 +580,48 @@ export default class LearningMaterialManagerComponent extends Component {
580580
</span>
581581
</div>
582582

583-
<div class="item timed-release-container">
583+
<div class="item timed-release">
584584
<label>
585585
{{t "general.timedRelease"}}:
586586
</label>
587587
<TimedReleaseSchedule @startDate={{this.startDate}} @endDate={{this.endDate}} />
588-
<div class="timed-release">
588+
<div class="timed-release-dates">
589589
{{#if this.startDate}}
590-
<div class="item start-date">
591-
<label>
592-
{{t "general.startDate"}}:
593-
</label>
594-
{{#if @editable}}
595-
<DatePicker
596-
@value={{this.startDate}}
597-
@onChange={{fn this.updateDate "startDate"}}
598-
/>
599-
{{else}}
600-
{{formatDate this.startDate day="2-digit" month="2-digit" year="numeric"}}
601-
{{/if}}
602-
</div>
603-
<div class="item start-time">
604-
<label>
605-
{{t "general.startTime"}}:
606-
</label>
607-
{{#if @editable}}
608-
<TimePicker
609-
@date={{this.startDate}}
610-
@action={{fn this.updateTime "startDate"}}
611-
/>
612-
{{else}}
613-
{{formatDate
614-
this.startDate
615-
day="2-digit"
616-
month="2-digit"
617-
year="numeric"
618-
hour12=true
619-
hour="2-digit"
620-
minute="2-digit"
621-
}}
622-
{{/if}}
590+
<div class="item start">
591+
<div class="start-date">
592+
<label>
593+
{{t "general.startDate"}}:
594+
</label>
595+
{{#if @editable}}
596+
<DatePicker
597+
@value={{this.startDate}}
598+
@onChange={{fn this.updateDate "startDate"}}
599+
/>
600+
{{else}}
601+
{{formatDate this.startDate day="2-digit" month="2-digit" year="numeric"}}
602+
{{/if}}
603+
</div>
604+
<div class="start-time">
605+
<label>
606+
{{t "general.startTime"}}:
607+
</label>
608+
{{#if @editable}}
609+
<TimePicker
610+
@date={{this.startDate}}
611+
@action={{fn this.updateTime "startDate"}}
612+
/>
613+
{{else}}
614+
{{formatDate
615+
this.startDate
616+
day="2-digit"
617+
month="2-digit"
618+
year="numeric"
619+
hour12=true
620+
hour="2-digit"
621+
minute="2-digit"
622+
}}
623+
{{/if}}
624+
</div>
623625
</div>
624626
{{#if @editable}}
625627
<button
@@ -643,42 +645,44 @@ export default class LearningMaterialManagerComponent extends Component {
643645
</p>
644646
{{/if}}
645647
{{#if this.endDate}}
646-
<div class="item end-date">
647-
<label>
648-
{{t "general.endDate"}}:
649-
</label>
650-
{{#if @editable}}
651-
<DatePicker
652-
@value={{this.endDate}}
653-
@onChange={{fn this.updateDate "endDate"}}
654-
/>
655-
{{else}}
656-
{{formatDate this.endDate day="2-digit" month="2-digit" year="numeric"}}
657-
{{/if}}
658-
</div>
659-
<div class="item end-time">
660-
<label>
661-
{{t "general.endTime"}}:
662-
</label>
663-
{{#if @editable}}
664-
<TimePicker @date={{this.endDate}} @action={{fn this.updateTime "endDate"}} />
665-
{{else}}
666-
{{formatDate
667-
this.endDate
668-
day="2-digit"
669-
month="2-digit"
670-
year="numeric"
671-
hour12=true
672-
hour="2-digit"
673-
minute="2-digit"
674-
}}
675-
{{/if}}
648+
<div class="item end">
649+
<div class="end-date">
650+
<label>
651+
{{t "general.endDate"}}:
652+
</label>
653+
{{#if @editable}}
654+
<DatePicker
655+
@value={{this.endDate}}
656+
@onChange={{fn this.updateDate "endDate"}}
657+
/>
658+
{{else}}
659+
{{formatDate this.endDate day="2-digit" month="2-digit" year="numeric"}}
660+
{{/if}}
661+
</div>
662+
<div class="end-time">
663+
<label>
664+
{{t "general.endTime"}}:
665+
</label>
666+
{{#if @editable}}
667+
<TimePicker @date={{this.endDate}} @action={{fn this.updateTime "endDate"}} />
668+
{{else}}
669+
{{formatDate
670+
this.endDate
671+
day="2-digit"
672+
month="2-digit"
673+
year="numeric"
674+
hour12=true
675+
hour="2-digit"
676+
minute="2-digit"
677+
}}
678+
{{/if}}
679+
</div>
680+
<YupValidationMessage
681+
@description={{t "general.endDate"}}
682+
@validationErrors={{this.validations.errors.endDate}}
683+
data-test-end-date-validation-error-message
684+
/>
676685
</div>
677-
<YupValidationMessage
678-
@description={{t "general.endDate"}}
679-
@validationErrors={{this.validations.errors.endDate}}
680-
data-test-end-date-validation-error-message
681-
/>
682686
{{#if @editable}}
683687
<button
684688
class="remove-date"

packages/ilios-common/app/styles/ilios-common/components/learningmaterial-manager.scss

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@
7070
margin: 0;
7171
}
7272

73-
@include m.for-laptop-and-up {
74-
.timed-release-container {
75-
grid-column: 1 / -1;
76-
}
77-
}
78-
7973
.timed-release {
8074
margin-bottom: 2rem;
8175

@@ -93,6 +87,13 @@
9387
min-width: 150px;
9488
}
9589

90+
.start,
91+
.end {
92+
display: flex;
93+
flex-direction: row;
94+
gap: 1em;
95+
}
96+
9697
.add-date {
9798
border: 1px solid var(--green);
9899
color: var(--green);
@@ -102,5 +103,9 @@
102103
border: 1px solid var(--red);
103104
color: var(--red);
104105
}
106+
107+
.time-picker {
108+
gap: 0.5em;
109+
}
105110
}
106111
}

0 commit comments

Comments
 (0)