linting

Author: HoneyryderChuck

lib/http/2/framer.rb

@@ -185,7 +185,7 @@ def read_common_header(buf)
       {
         type: type,
         flags: FRAME_FLAGS[type].filter_map do |name, pos|
-          name if flags.anybits?((1 << pos))
+          name if flags.anybits?(1 << pos)
         end,
         length: length,
         stream: stream & RBIT
@@ -359,7 +359,7 @@ def generate(frame)
         # Padding:  Padding octets that contain no application semantic value.
         # Padding octets MUST be set to zero when sending and ignored when
         # receiving.
-        append_str(bytes, ("\0" * padlen))
+        append_str(bytes, "\0" * padlen)
       end
 
       frame[:length] = length

lib/http/2/header/huffman.rb

@@ -29,7 +29,7 @@ module Huffman
       def encode(str, buffer = "".b)
         bitstring = String.new("", encoding: Encoding::BINARY, capacity: (str.bytesize * 30) + ((8 - str.size) % 8))
         str.each_byte { |chr| append_str(bitstring, ENCODE_TABLE[chr]) }
-        append_str(bitstring, ("1" * ((8 - bitstring.size) % 8)))
+        append_str(bitstring, "1" * ((8 - bitstring.size) % 8))
         pack([bitstring], "B*", buffer: buffer)
       end
 

spec/connection_spec.rb

@@ -4,6 +4,7 @@
 
 RSpec.describe HTTP2::Connection do
   include FrameHelpers
+
   let(:conn) { Client.new }
   let(:f) { Framer.new }
 

spec/emitter_spec.rb

@@ -5,6 +5,7 @@
 RSpec.describe HTTP2::Emitter do
   class Worker
     include Emitter
+
     def initialize
       @listeners = Hash.new { |hash, key| hash[key] = [] }
     end

spec/stream_spec.rb

@@ -4,6 +4,7 @@
 
 RSpec.describe HTTP2::Stream do
   include FrameHelpers
+
   let(:f) { Framer.new }
   let(:client) { Client.new }
   let(:stream) { client.new_stream }

tasks/generate_huffman_table.rb

@@ -28,7 +28,7 @@ def add(code, len, chr)
       if len.zero?
         @emit = chr
       else
-        bit = code.nobits?((1 << (len - 1))) ? 0 : 1
+        bit = code.nobits?(1 << (len - 1)) ? 0 : 1
         node = @next[bit] ||= Node.new(@depth + 1)
         node.add(code, len - 1, chr)
       end
@@ -70,7 +70,7 @@ def self.generate_machine
           n = node
           emit = "".b
           (BITS_AT_ONCE - 1).downto(0) do |i|
-            bit = input.nobits?((1 << i)) ? 0 : 1
+            bit = input.nobits?(1 << i) ? 0 : 1
             n = n.next[bit]
             next unless n.emit
 
@@ -123,7 +123,7 @@ class Huffman
         id.times do |i|
           n = id_state[i]
           f.print "        ["
-          string = Array.new((1 << 4)) do |t|
+          string = Array.new(1 << 4) do |t|
             transition = n.transitions.fetch(t)
             emit = transition.emit
             unless emit == EOS