Add comprehensive RTL (right-to-left) support #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor docs website improvements
Minor docs website updates
Update dev deps
Update deps
Bump package version
Update dev deps
Update deps, changelog, license year
Update deps, changelog, bump version
Update deps & bump version
Release 8.3.7
Trying to update deployment workflow step versions
Release 8.3.8
Update dev deps, bump version
Implements full RTL layout support for Arabic, Hebrew, Persian, and other right-to-left languages, with automatic detection via Mantine's DirectionProvider. Core changes: - Menu positioning: Appears left of cursor in RTL mode with proper viewport bounds - Submenu positioning: Opens to the left of parent items in RTL layouts - Text direction: Proper text alignment and reading direction - Icon spacing: Uses logical CSS properties (margin-inline-start/end) for automatic flipping - Submenu indicators: Arrow character automatically mirrors based on text direction Technical implementation: - ContextMenuProvider: Detects direction using Mantine's useDirection hook - ContextMenu: Calculates RTL-aware position (x - width vs x + width) - ContextMenuItem: Sets dir attribute and uses logical margin properties - Prevents visual flash on mount by waiting for dimensions before showing - Maintains smooth repositionOnRepeat transitions while avoiding initial flash Includes comprehensive example page with: - Interactive RTL/LTR toggle - Detailed explanations of RTL behavior - Code examples for proper DirectionProvider setup - Multi-level submenu demonstrations
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Author
|
Would love for this to get merged as soon as possible :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements full RTL layout support for Arabic, Hebrew, Persian, and other right-to-left languages, with automatic detection via Mantine's DirectionProvider.
Core changes:
Technical implementation:
Includes comprehensive example page with: