Bugfixes #646
Open
Bugfixes #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 22, 2025 12:32
- Increase remote job timeout to 120 minutes in any case - Fix broken file locking
connections until state is known - Revert logic for distributing some jobs to idle servers. The replaced logic always evaluates to false. - Degrade 'no server found behind given hostname' to warning. This can happend when a server disconnects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several bugfixes:
Fix wrong logic in scheduling jobs fist-in-first-out
Logic was not working to take oldest jobs first (FIFO) which could make linker jobs pending for a very long time, eventually leading to a timeout.
Increase remote job timeout to 120 minutes in any case
For very big projcets with many linker jobs, jobs can be pending for a long time. Especially in combination with the bug above. The lower 40 minute timeout on non-full jobs is not really a useful timeout anyway. Its a long time anyway if the job really ends up hanging in this state.
Fix broken file locking
The job timeout desribed above leads to local compiling without iccecc using file locking instead. If exec() is not called from the forked subprocess these locks will be closed and not working. Leading to unlimited number of local jobs running. This also happends if icecc is used without the iceccd daemon running.
change default state of noRemote and acceptingInConnection
To prevent connections to servers until their state is known.
Revert logic for distributing some jobs to idle servers.
The replaced logic always evaluates to false.
Degrade 'no server found behind given hostname' to warning.
This can happend when a server disconnects.
postpone connection test for 5 minutes for lost reconnecting serves
To prevent scheduling jobs on unstable servers