Migrated Ical.Net.Tests project from NUnit3 to NUnit 4 #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Migrate NUnit 3.14.0 to 4.2.2 * Add NUnit.Analyzers 4.3.0 * Convert Classic Assert to Constraint Model * Introduce Assert.Multiple to group assertions, ensuring all are evaluated even if some fail. * Simplify test case source return types to IEnumerable without a type argument * Remove unused using directives and added necessary ones. Test logic is left unchanged except for 7 tests in Exception context. Here all try...catch blocks are replaced with `Throws.` assertions.
axunonb
changed the title
Collaborator
Author
|
@minichma Please take a look, if time allows. Can we merge this PR? |
Collaborator
|
Sure, will have a look right now. |
minichma
previously approved these changes
Oct 19, 2024
Collaborator
minichma
left a comment
minichma
left a comment
There was a problem hiding this comment.
LGTM. Was just a very quick review, more an optical one. Found just a few formatting issues.
|
This was referenced Jul 28, 2025
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test logic is left unchanged except for 7 tests in Exception context.
Here all try...catch blocks are replaced with
Throws.assertions.Closes #611