Remove unused ILoggerT, implement IDisposable pattern for NullLoggerFactory

Author: axunonb

Ical.Net/Logging/ILoggerT.cs

@@ -3,14 +3,18 @@
 // Licensed under the MIT license.
 //
 
+using System;
+
 namespace Ical.Net.Logging.Internal;
 
 /// <summary>
 /// Provides a no-operation implementation of <see cref="ILoggerFactory"/> that produces <see cref="NullLogger"/>
 /// instances. This factory is intended for scenarios where logging is not required or should be disabled.
 /// </summary>
-internal class NullLoggerFactory : ILoggerFactory
+internal sealed class NullLoggerFactory : ILoggerFactory
 {
+    private bool _disposed;
+
     /// <summary>
     /// Provides a singleton instance of a <see cref="NullLoggerFactory"/> that produces no-op loggers.
     /// </summary>
@@ -25,9 +29,22 @@ private NullLoggerFactory() { }
     /// <returns>A <see cref="NullLogger.Instance"/></returns>
     public ILogger CreateLogger(string categoryName) => NullLogger.Instance;
 
+    private void Dispose(bool _) //NOSONAR
+    {
+        if (_disposed) return;
+        // No resources to release, implement IDisposable pattern for consistency
+        _disposed = true;
+    }
+
     /// <inheritdoc/>
     public void Dispose()
     {
-        // no-op
+        Dispose(true);
+        GC.SuppressFinalize(this);
+    }
+
+    ~NullLoggerFactory()
+    {
+        Dispose(false);
     }
 }

Ical.Net/Logging/Internal/NullLoggerFactory.cs

@@ -53,11 +53,11 @@ internal static ILogger CreateLogger(string categoryName)
         => (_loggerFactory.Value ?? NullLoggerFactory.Instance).CreateLogger(categoryName);
 
     /// <summary>
-    /// Gets an <see cref="ILogger{T}"/> instance for the specified type.
+    /// Gets an <see cref="ILogger"/> instance for the specified type.
     /// The category name will be the full name of the type T.
     /// </summary>
     /// <typeparam name="T">The type for which to create the logger.</typeparam>
-    /// <returns>An <see cref="ILogger{T}"/> instance.</returns>
+    /// <returns>An <see cref="ILogger"/> instance.</returns>
     internal static ILogger CreateLogger<T>()
         => new Logger<T>(_loggerFactory.Value ?? NullLoggerFactory.Instance);