Remove GetOccurrences.GetOccurrencesOfDay() and related.

Author: minichma

Ical.Net.Tests/GetOccurrenceTests.cs

@@ -145,7 +145,7 @@ public void EnumerationChangedException()
 
         var calendar = GetCalendars(ical);
         var date = new DateTime(2016, 10, 11);
-        var occurrences = calendar.GetOccurrencesOfDay(date).ToList();
+        var occurrences = calendar.GetOccurrences(date, date.AddDays(1)).ToList();
 
         //We really want to make sure this doesn't explode
         Assert.That(occurrences, Has.Count.EqualTo(1));

Ical.Net.Tests/RecurrenceTests.cs

@@ -3806,7 +3806,7 @@ public void GetOccurrenceShouldExcludeDtEndFloating()
 
         var calendar = Calendar.Load(ical);
         // Set start date for occurrences to search to the end date of the event
-        var occurrences = calendar.GetOccurrencesOfDay(new CalDateTime(2024, 12, 2));
+        var occurrences = calendar.GetOccurrences(new CalDateTime(2024, 12, 2), new CalDateTime(2024, 12, 3));
 
         Assert.That(occurrences, Is.Empty);
     }

Ical.Net/Calendar.cs

@@ -197,24 +197,6 @@ public VTimeZone AddTimeZone(VTimeZone tz)
         return tz;
     }
 
-
-    /// <summary>
-    /// Returns a list of occurrences of each recurring component
-    /// for the date provided (<paramref name="dt"/>).
-    /// </summary>
-    /// <param name="dt">The date for which to return occurrences. Time is ignored on this parameter.</param>
-    /// <returns>A list of occurrences that occur on the given date (<paramref name="dt"/>).</returns>
-    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(IDateTime dt)
-    {
-        return GetOccurrences<IRecurringComponent>(new CalDateTime(dt.Date), new CalDateTime(dt.Date.AddDays(1)));
-    }
-
-    /// <inheritdoc cref="GetOccurrencesOfDay(IDateTime)"/>
-    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(DateTime dt)
-    {
-        return GetOccurrences<IRecurringComponent>(new CalDateTime(DateOnly.FromDateTime(dt)), new CalDateTime(DateOnly.FromDateTime(dt.Date.AddDays(1))));
-    }
-
     /// <summary>
     /// Returns a list of occurrences of each recurring component
     /// that occur between <paramref name="startTime"/> and <paramref name="endTime"/>.
@@ -229,29 +211,6 @@ public virtual IEnumerable<Occurrence> GetOccurrences(IDateTime startTime = null
     public virtual IEnumerable<Occurrence> GetOccurrences(DateTime? startTime, DateTime? endTime)
         => GetOccurrences<IRecurringComponent>(startTime?.AsCalDateTime(), endTime?.AsCalDateTime());
 
-    /// <summary>
-    /// Returns all occurrences of components of type T that start on the date provided.
-    /// All components starting between 12:00:00AM and 11:59:59 PM will be
-    /// returned.
-    /// <note>
-    /// This will first Evaluate() the date range required in order to
-    /// determine the occurrences for the date provided, and then return
-    /// the occurrences.
-    /// </note>
-    /// </summary>
-    /// <param name="dt">The date for which to return occurrences. Time is ignored on this parameter.</param>
-    /// <returns>A list of Periods representing the occurrences of this object.</returns>
-    public virtual IEnumerable<Occurrence> GetOccurrences<T>(IDateTime dt) where T : IRecurringComponent
-    {
-        return GetOccurrences<T>(new CalDateTime(dt.Date), new CalDateTime(dt.Date.AddDays(1)));
-    }
-
-    /// <inheritdoc cref="GetOccurrencesOfDay(IDateTime)"/>
-    public virtual IEnumerable<Occurrence> GetOccurrences<T>(DateTime dt) where T : IRecurringComponent
-    {
-        return GetOccurrences<T>(new CalDateTime(DateOnly.FromDateTime(dt)), new CalDateTime(DateOnly.FromDateTime(dt.Date.AddDays(1))));
-    }
-
     /// <inheritdoc cref="GetOccurrences(IDateTime, IDateTime)"/>
     public virtual IEnumerable<Occurrence> GetOccurrences<T>(DateTime? startTime, DateTime? endTime) where T : IRecurringComponent
         => GetOccurrences<T>(startTime?.AsCalDateTime(), endTime?.AsCalDateTime());

Ical.Net/CalendarCollection.cs

@@ -39,16 +39,6 @@ public static CalendarCollection Load(TextReader tr)
         return collection;
     }
 
-    public HashSet<Occurrence> GetOccurrencesOfDay(IDateTime dt)
-    {
-        var occurrences = new HashSet<Occurrence>();
-        foreach (var iCal in this)
-        {
-            occurrences.UnionWith(iCal.GetOccurrencesOfDay(dt));
-        }
-        return occurrences;
-    }
-
     private IEnumerable<Occurrence> GetOccurrences(Func<Calendar, IEnumerable<Occurrence>> f)
         =>
 
@@ -65,21 +55,12 @@ private IEnumerable<Occurrence> GetOccurrences(Func<Calendar, IEnumerable<Occurr
         // being ordered to avoid full enumeration.
         .OrderedMergeMany();
 
-    public IEnumerable<Occurrence> GetOccurrencesOfDay(DateTime dt)
-        => GetOccurrences(iCal => iCal.GetOccurrencesOfDay(dt));
-
     public IEnumerable<Occurrence> GetOccurrences(IDateTime startTime, IDateTime endTime)
         => GetOccurrences(iCal => iCal.GetOccurrences(startTime, endTime));
 
     public IEnumerable<Occurrence> GetOccurrences(DateTime? startTime, DateTime? endTime)
         => GetOccurrences(iCal => iCal.GetOccurrences(startTime, endTime));
 
-    public IEnumerable<Occurrence> GetOccurrences<T>(IDateTime dt) where T : IRecurringComponent
-        => GetOccurrences(iCal => iCal.GetOccurrencesOfDay(dt));
-
-    public IEnumerable<Occurrence> GetOccurrences<T>(DateTime dt) where T : IRecurringComponent
-        => GetOccurrences(iCal => iCal.GetOccurrences<T>(dt));
-
     public IEnumerable<Occurrence> GetOccurrences<T>(IDateTime startTime, IDateTime endTime) where T : IRecurringComponent
         => GetOccurrences(iCal => iCal.GetOccurrences<T>(startTime, endTime));
 

Ical.Net/CalendarComponents/RecurringComponent.cs

@@ -178,11 +178,6 @@ protected override void OnDeserializing(StreamingContext context)
         Initialize();
     }
 
-    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(IDateTime dt) => RecurrenceUtil.GetOccurrences(this, dt, EvaluationIncludesReferenceDate);
-
-    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(DateTime dt)
-        => RecurrenceUtil.GetOccurrences(this, new CalDateTime(dt), EvaluationIncludesReferenceDate);
-
     public virtual IEnumerable<Occurrence> GetOccurrences(IDateTime startTime, IDateTime endTime)
         => RecurrenceUtil.GetOccurrences(this, startTime, endTime, EvaluationIncludesReferenceDate);
 

Ical.Net/IGetOccurrences.cs

@@ -12,22 +12,6 @@ namespace Ical.Net;
 
 public interface IGetOccurrences
 {
-    /// <summary>
-    /// Returns all occurrences of this component that start on the date provided.
-    /// All components starting between 12:00:00AM and 11:59:59 PM will be
-    /// returned.
-    /// <note>
-    /// This will first Evaluate() the date range required in order to
-    /// determine the occurrences for the date provided, and then return
-    /// the occurrences.
-    /// </note>
-    /// </summary>
-    /// <param name="dt">The date for which to return occurrences.</param>
-    /// <returns>An IEnumerable that calculates and returns Periods representing the occurrences of this object in ascending order.</returns>
-    IEnumerable<Occurrence> GetOccurrencesOfDay(IDateTime dt);
-
-    IEnumerable<Occurrence> GetOccurrencesOfDay(DateTime dt);
-
     /// <summary>
     /// Returns all occurrences of this component that overlap with the date range provided.
     /// All components that overlap with the time range between <paramref name="startTime"/> and <paramref name="endTime"/> will be returned.
@@ -42,22 +26,6 @@ public interface IGetOccurrences
 
 public interface IGetOccurrencesTyped : IGetOccurrences
 {
-    /// <summary>
-    /// Returns all occurrences of components of type T that start on the date provided.
-    /// All components starting between 12:00:00AM and 11:59:59 PM will be
-    /// returned.
-    /// <note>
-    /// This will first Evaluate() the date range required in order to
-    /// determine the occurrences for the date provided, and then return
-    /// the occurrences.
-    /// </note>
-    /// </summary>
-    /// <param name="dt">The date for which to return occurrences.</param>
-    /// <returns>An IEnumerable that calculates and returns Periods representing the occurrences of this object in ascending order.</returns>
-    IEnumerable<Occurrence> GetOccurrences<T>(IDateTime dt) where T : IRecurringComponent;
-
-    IEnumerable<Occurrence> GetOccurrences<T>(DateTime dt) where T : IRecurringComponent;
-
     /// <summary>
     /// Returns all occurrences of components of type T that start within the date range provided.
     /// All components occurring between <paramref name="startTime"/> and <paramref name="endTime"/>

Ical.Net/VTimeZoneInfo.cs

@@ -172,12 +172,6 @@ public virtual IDateTime RecurrenceId
         set => Properties.Set("RECURRENCE-ID", value);
     }
 
-    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(IDateTime dt)
-        => RecurrenceUtil.GetOccurrences(this, dt, true);
-
-    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(DateTime dt)
-        => RecurrenceUtil.GetOccurrences(this, new CalDateTime(dt), true);
-
     public virtual IEnumerable<Occurrence> GetOccurrences(IDateTime startTime, IDateTime endTime)
         => RecurrenceUtil.GetOccurrences(this, startTime, endTime, true);