Rename IGetOccurrences.GetOccurrences(dt) overload for getting the occurrences of a single day to GetOccurrencesOfDay() to avoid ambiguities with the other overloads.

Author: minichma

Ical.Net.Tests/GetOccurrenceTests.cs

@@ -145,7 +145,7 @@ public void EnumerationChangedException()
 
         var calendar = GetCalendars(ical);
         var date = new DateTime(2016, 10, 11);
-        var occurrences = calendar.GetOccurrences(date).ToList();
+        var occurrences = calendar.GetOccurrencesOfDay(date).ToList();
 
         //We really want to make sure this doesn't explode
         Assert.That(occurrences, Has.Count.EqualTo(1));

Ical.Net.Tests/RecurrenceTests.cs

@@ -3806,7 +3806,7 @@ public void GetOccurrenceShouldExcludeDtEndFloating()
 
         var calendar = Calendar.Load(ical);
         // Set start date for occurrences to search to the end date of the event
-        var occurrences = calendar.GetOccurrences(new CalDateTime(2024, 12, 2));
+        var occurrences = calendar.GetOccurrencesOfDay(new CalDateTime(2024, 12, 2));
 
         Assert.That(occurrences, Is.Empty);
     }

Ical.Net/Calendar.cs

@@ -204,13 +204,13 @@ public VTimeZone AddTimeZone(VTimeZone tz)
     /// </summary>
     /// <param name="dt">The date for which to return occurrences. Time is ignored on this parameter.</param>
     /// <returns>A list of occurrences that occur on the given date (<paramref name="dt"/>).</returns>
-    public virtual IEnumerable<Occurrence> GetOccurrences(IDateTime dt)
+    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(IDateTime dt)
     {
         return GetOccurrences<IRecurringComponent>(new CalDateTime(dt.Date), new CalDateTime(dt.Date.AddDays(1)));
     }
 
-    /// <inheritdoc cref="GetOccurrences(IDateTime)"/>
-    public virtual IEnumerable<Occurrence> GetOccurrences(DateTime dt)
+    /// <inheritdoc cref="GetOccurrencesOfDay(IDateTime)"/>
+    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(DateTime dt)
     {
         return GetOccurrences<IRecurringComponent>(new CalDateTime(DateOnly.FromDateTime(dt)), new CalDateTime(DateOnly.FromDateTime(dt.Date.AddDays(1))));
     }
@@ -246,7 +246,7 @@ public virtual IEnumerable<Occurrence> GetOccurrences<T>(IDateTime dt) where T :
         return GetOccurrences<T>(new CalDateTime(dt.Date), new CalDateTime(dt.Date.AddDays(1)));
     }
 
-    /// <inheritdoc cref="GetOccurrences(IDateTime)"/>
+    /// <inheritdoc cref="GetOccurrencesOfDay(IDateTime)"/>
     public virtual IEnumerable<Occurrence> GetOccurrences<T>(DateTime dt) where T : IRecurringComponent
     {
         return GetOccurrences<T>(new CalDateTime(DateOnly.FromDateTime(dt)), new CalDateTime(DateOnly.FromDateTime(dt.Date.AddDays(1))));

Ical.Net/CalendarCollection.cs

@@ -39,19 +39,19 @@ public static CalendarCollection Load(TextReader tr)
         return collection;
     }
 
-    public HashSet<Occurrence> GetOccurrences(IDateTime dt)
+    public HashSet<Occurrence> GetOccurrencesOfDay(IDateTime dt)
     {
         var occurrences = new HashSet<Occurrence>();
         foreach (var iCal in this)
         {
-            occurrences.UnionWith(iCal.GetOccurrences(dt));
+            occurrences.UnionWith(iCal.GetOccurrencesOfDay(dt));
         }
         return occurrences;
     }
 
-    public IEnumerable<Occurrence> GetOccurrences(DateTime dt)
+    public IEnumerable<Occurrence> GetOccurrencesOfDay(DateTime dt)
         => this
-        .Select(iCal => iCal.GetOccurrences(dt))
+        .Select(iCal => iCal.GetOccurrencesOfDay(dt))
         .ToArray()
         .OrderedMergeMany();
 
@@ -69,7 +69,7 @@ public IEnumerable<Occurrence> GetOccurrences(DateTime? startTime, DateTime? end
 
     public IEnumerable<Occurrence> GetOccurrences<T>(IDateTime dt) where T : IRecurringComponent
         => this
-        .Select(iCal => iCal.GetOccurrences(dt))
+        .Select(iCal => iCal.GetOccurrencesOfDay(dt))
         .ToArray()
         .OrderedMergeMany();
 

Ical.Net/CalendarComponents/RecurringComponent.cs

@@ -178,9 +178,9 @@ protected override void OnDeserializing(StreamingContext context)
         Initialize();
     }
 
-    public virtual IEnumerable<Occurrence> GetOccurrences(IDateTime dt) => RecurrenceUtil.GetOccurrences(this, dt, EvaluationIncludesReferenceDate);
+    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(IDateTime dt) => RecurrenceUtil.GetOccurrences(this, dt, EvaluationIncludesReferenceDate);
 
-    public virtual IEnumerable<Occurrence> GetOccurrences(DateTime dt)
+    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(DateTime dt)
         => RecurrenceUtil.GetOccurrences(this, new CalDateTime(dt), EvaluationIncludesReferenceDate);
 
     public virtual IEnumerable<Occurrence> GetOccurrences(IDateTime startTime, IDateTime endTime)

Ical.Net/IGetOccurrences.cs

@@ -24,9 +24,9 @@ public interface IGetOccurrences
     /// </summary>
     /// <param name="dt">The date for which to return occurrences.</param>
     /// <returns>An IEnumerable that calculates and returns Periods representing the occurrences of this object in ascending order.</returns>
-    IEnumerable<Occurrence> GetOccurrences(IDateTime dt);
+    IEnumerable<Occurrence> GetOccurrencesOfDay(IDateTime dt);
 
-    IEnumerable<Occurrence> GetOccurrences(DateTime dt);
+    IEnumerable<Occurrence> GetOccurrencesOfDay(DateTime dt);
 
     /// <summary>
     /// Returns all occurrences of this component that overlap with the date range provided.

Ical.Net/VTimeZoneInfo.cs

@@ -160,10 +160,10 @@ public virtual IDateTime RecurrenceId
         set => Properties.Set("RECURRENCE-ID", value);
     }
 
-    public virtual IEnumerable<Occurrence> GetOccurrences(IDateTime dt)
+    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(IDateTime dt)
         => RecurrenceUtil.GetOccurrences(this, dt, true);
 
-    public virtual IEnumerable<Occurrence> GetOccurrences(DateTime dt)
+    public virtual IEnumerable<Occurrence> GetOccurrencesOfDay(DateTime dt)
         => RecurrenceUtil.GetOccurrences(this, new CalDateTime(dt), true);
 
     public virtual IEnumerable<Occurrence> GetOccurrences(IDateTime startTime, IDateTime endTime)