Make Stateful call custom setters/getters for function properties too.

Also changed the naming of the shadow properties to avoid a conflict where
the getTextDir() property got a shadow property called _getTextDirAttr(),
which looked like a custom getter for the textdir property.
This shouldn't affect existing code assuming it uses this.get("prop")
rather than using the name of the shadow property directly.

Fixes #52 and refs ibm-js/delite#314.

Author: wkeese

Stateful.js

@@ -17,12 +17,11 @@ define([
 		var uc = name.replace(/^[a-z]|-[a-zA-Z]/g, function (c) {
 			return c.charAt(c.length - 1).toUpperCase();
 		});
-		var ret = apn[name] = {
-			p: "_" + name + "Attr",		// shadow property, since real property hidden by setter/getter
+		return apn[name] = {
+			p: "_shadow" + uc + "Attr",	// shadow property, since real property hidden by setter/getter
 			s: "_set" + uc + "Attr",	// converts dashes to camel case, ex: accept-charset --> _setAcceptCharsetAttr
 			g: "_get" + uc + "Attr"
 		};
-		return ret;
 	}
 
 	/**
@@ -38,7 +37,7 @@ define([
 		});
 	}
 
-	var REGEXP_SHADOW_PROPS = /^_(.+)Attr$/;
+	var REGEXP_IGNORE_PROPS = /^constructor$|^_set$|^_get$|^deliver$|^discardChanges$|^_(.+)Attr$/;
 
 	/**
 	 * Base class for objects that provide named properties with optional getter/setter
@@ -82,7 +81,7 @@ define([
 		getProps: function () {
 			var hash = {};
 			for (var prop in this) {
-				if (typeof this[prop] !== "function" && !REGEXP_SHADOW_PROPS.test(prop)) {
+				if (!REGEXP_IGNORE_PROPS.test(prop)) {
 					hash[prop] = true;
 				}
 			}

tests/unit/Stateful.js

@@ -13,7 +13,7 @@ define([
 				baz: "",
 
 				_getFooAttr: function () {
-					return this._fooAttr - 1;
+					return this._get("foo") - 1;
 				},
 
 				_setBarAttr: function (value) {
@@ -391,6 +391,7 @@ define([
 			// Check to make sure reported changes are consistent between platforms with and without Object.observe()
 			// native support
 			var dfd = this.async(1000),
+				nop = function () {},
 				stateful = new (dcl(Stateful, {
 					_private: 1,
 
@@ -403,12 +404,13 @@ define([
 						this.instanceProp = 3;
 					},
 
-					anotherFunc: function () { }
+					anotherFunc: nop
 				}))({});
 			stateful.observe(dfd.callback(function (oldValues) {
 				assert.deepEqual(oldValues, {
 					_private: 1,
-					foo: 2
+					foo: 2,
+					anotherFunc: nop
 				});
 			}));
 			stateful._private = 11;