fix(editor/util/validation): Fix stop name validation.

binh-dam-ibigroup · binh-dam-ibigroup · commit ef69da36f4a4 · 2021-07-19T17:03:07.000-04:00
diff --git a/lib/editor/util/validation.js b/lib/editor/util/validation.js
@@ -136,7 +136,11 @@ export function validate (
         return false
       }
     case 'TEXT':
-      if (name === 'stop_name' && locationType !== null && (typeof locationType === 'number' && locationType <= 2)) {
+      if (name === 'stop_name' &&
+          !value &&
+          locationType !== null &&
+          (typeof locationType === 'number' && locationType <= 2)
+      ) {
         return validationIssue('Stop name is required for stop, station, and entrance location types.')
       }
       if (name === 'route_short_name' && !value && entity && entity.route_long_name) {

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,11 @@ export function validate (`
`136`	`136`	`return false`
`137`	`137`	`}`
`138`	`138`	`case 'TEXT':`
`139`		`- if (name === 'stop_name' && locationType !== null && (typeof locationType === 'number' && locationType <= 2)) {`
	`139`	`+ if (name === 'stop_name' &&`
	`140`	`+ !value &&`
	`141`	`+ locationType !== null &&`
	`142`	`+ (typeof locationType === 'number' && locationType <= 2)`
	`143`	`+ ) {`
`140`	`144`	`return validationIssue('Stop name is required for stop, station, and entrance location types.')`
`141`	`145`	`}`
`142`	`146`	`if (name === 'route_short_name' && !value && entity && entity.route_long_name) {`