fix(actions/manager/deployments): Suggest zip name based on deployment name.

Author: binh-dam-ibigroup

lib/manager/actions/deployments.js

@@ -5,13 +5,13 @@ import { browserHistory } from 'react-router'
 import { createAction, type ActionType } from 'redux-actions'
 
 import { createVoidPayloadAction, secureFetch } from '../../common/actions'
-import { receiveProject } from './projects'
-import { startJobMonitor } from './status'
 import fileDownload from '../../common/util/file-download'
-
 import type {Deployment, Feed, SummarizedFeedVersion} from '../../types'
 import type {dispatchFn, getStateFn} from '../../types/reducers'
 
+import { startJobMonitor } from './status'
+import { receiveProject } from './projects'
+
 const DEPLOYMENT_URL = `/api/manager/secure/deployments`
 
 // Deployment Actions
@@ -132,11 +132,28 @@ export function downloadBuildArtifact (deployment: Deployment, filename: ?string
   }
 }
 
+/**
+ * Set a suggested file name for the given deployment.
+ *
+ * Note: Although a suggested file name is returned in the 'content-disposition' header of the 'download' endpoint,
+ * it is still needed to set it here because we trigger the "Save As" dialog separately from the actual fetch.
+ * Also, it is probably simpler to recompute the file name here instead of extracting it from the response.
+ *
+ * @param deployment The deployment object from which to derive the zip file name.
+ * @returns The suggested zip file name ending in ".zip" for the browser "Save As" dialog.
+ */
+function getDeploymentZipFileName (deployment: Deployment): string {
+  // Remove all spaces and special chars from deployment name.
+  const zipBase = deployment.name.replace(/[^a-zA-Z0-9]/g, '')
+  return `${zipBase}.zip`
+}
+
 export function downloadDeployment (deployment: Deployment) {
   return function (dispatch: dispatchFn, getState: getStateFn) {
+    const zipName = getDeploymentZipFileName(deployment)
     return dispatch(secureFetch(`${DEPLOYMENT_URL}/${deployment.id}/download`))
       .then(response => response.blob())
-      .then(blob => fileDownload(blob, 'test.zip', 'application/zip'))
+      .then(blob => fileDownload(blob, zipName, 'application/zip'))
   }
 }