fix(editor): prevent reversing pattern if pattern has trips

fixes #104

Author: landonreed

lib/editor/components/pattern/TripPatternListControls.js

@@ -8,12 +8,12 @@ import {generateUID} from '../../../common/util/util'
 import {entityIsNew} from '../../util/objects'
 
 export default class TripPatternListControls extends Component {
-  _onClickClone = () => {
+  _onClickClonePattern = () => {
     const {activePattern, cloneEntity, feedSource} = this.props
     cloneEntity(feedSource.id, 'trippattern', activePattern.id, true)
   }
 
-  _onClickDelete = () => {
+  _onClickDeletePattern = () => {
     const {
       activeEntity,
       activePattern,
@@ -61,7 +61,7 @@ export default class TripPatternListControls extends Component {
    * the order of the shape points. NOTE: this does not change the travel times
    * for the pattern stops.
    */
-  _onClickReverse = () => {
+  _onClickReversePattern = () => {
     const {
       activePattern,
       controlPoints,
@@ -79,6 +79,7 @@ export default class TripPatternListControls extends Component {
         const patternStops = [...activePattern.patternStops]
           // Reverse sort on existing stopSequence values
           .sort((a, b) => b.stopSequence - a.stopSequence)
+          // Update sequence for new order.
           .map((ps, i) => ({
             ...ps,
             stopSequence: i
@@ -98,8 +99,9 @@ export default class TripPatternListControls extends Component {
   }
 
   render () {
-    const {activePatternId, activeEntity} = this.props
+    const {activeEntity, activePatternId, activePatternTripCount} = this.props
     const {tripPatterns} = activeEntity
+    const patternHasTrips = activePatternTripCount > 0
     const createPatternDisabled = tripPatterns && tripPatterns.findIndex(entityIsNew) !== -1
     return (
       <div
@@ -112,8 +114,12 @@ export default class TripPatternListControls extends Component {
               overlay={<Tooltip id='tooltip'>Reverse trip pattern</Tooltip>}>
               <Button
                 bsSize='small'
-                disabled={!activePatternId}
-                onClick={this._onClickReverse}>
+                title={patternHasTrips
+                  ? 'Cannot reverse patterns that have trips'
+                  : 'Select pattern to reverse'}
+                // Do not allow reversing trip pattern if it has trips
+                disabled={!activePatternId || patternHasTrips}
+                onClick={this._onClickReversePattern}>
                 <Icon type='exchange' />
               </Button>
             </OverlayTrigger>
@@ -123,7 +129,7 @@ export default class TripPatternListControls extends Component {
               <Button
                 bsSize='small'
                 disabled={!activePatternId}
-                onClick={this._onClickClone}>
+                onClick={this._onClickClonePattern}>
                 <Icon type='clone' />
               </Button>
             </OverlayTrigger>
@@ -133,7 +139,7 @@ export default class TripPatternListControls extends Component {
               <Button
                 bsSize='small'
                 disabled={!activePatternId}
-                onClick={this._onClickDelete}>
+                onClick={this._onClickDeletePattern}>
                 <Icon type='trash' />
               </Button>
             </OverlayTrigger>