-
-
Notifications
You must be signed in to change notification settings - Fork 356
Closed
Description
In 3.1.8, a bunch of styles have been updated to use scoped style and the use of elements styling like input {} rules are used.
This is both bad practices I believe.
-
Scoped styles - add specificity to the base styling, making it hard to be overwritten. E.g.
.dropdown-item[data-xxx]has specificity of 2. -
Element styles - Even if this is scoped, it still inherits project's base styling. E.g.
input[data-xxx]inherits project'sinputstyles.
Ideally this project classes should be neutral. Examples like:
.vue-tel-input {}
.vti__iti-flag {}
.vti__selection {}
.vti__dropdown-menu.show {} // Keep this to minimum
.vti__input {}
.vti__ul {}
This way all the styles:
- Are scoped to the project name
- Does not inherit default input styles
- Are easy to overwrite.
iamstevendao
Metadata
Metadata
Assignees
Labels
No labels