Skip to content

Commit 4b74d88

Browse files
authored
fix: bump @opentelemetry/instrumentation-net pkg + silence otel logs by default (#73)
* fix: bump net instrumentation pkg to v0.32.4 * fix: set default otel log level to error * fix: silence otel log by default * docs: add changeset
1 parent 04459c5 commit 4b74d88

File tree

4 files changed

+34
-2
lines changed

4 files changed

+34
-2
lines changed

.changeset/thirty-pandas-play.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@hyperdx/node-opentelemetry': patch
3+
---
4+
5+
fix: bump @opentelemetry/instrumentation-net pkg + silence otel logs by default

packages/node-opentelemetry/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
"@hyperdx/node-logger": "~0.3.0-next.0",
3636
"@opentelemetry/api": "^1.6.0",
3737
"@opentelemetry/auto-instrumentations-node": "~0.37.1",
38+
"@opentelemetry/instrumentation-net": "~0.32.4",
3839
"@opentelemetry/core": "~1.15.2",
3940
"@opentelemetry/exporter-metrics-otlp-proto": "~0.41.2",
4041
"@opentelemetry/exporter-trace-otlp-proto": "~0.41.2",

packages/node-opentelemetry/src/otel.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { NetInstrumentation } from '@opentelemetry/instrumentation-net';
12
import { NodeSDK } from '@opentelemetry/sdk-node';
23
import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-proto';
34
import {
@@ -43,7 +44,7 @@ export const initSDK = (config: SDKConfig) => {
4344
env.OTEL_EXPORTER_OTLP_ENDPOINT =
4445
env.OTEL_EXPORTER_OTLP_ENDPOINT ?? 'https://in-otel.hyperdx.io';
4546
env.OTEL_NODE_RESOURCE_DETECTORS = env.OTEL_NODE_RESOURCE_DETECTORS ?? 'all';
46-
env.OTEL_LOG_LEVEL = env.OTEL_LOG_LEVEL ?? 'info';
47+
env.OTEL_LOG_LEVEL = env.OTEL_LOG_LEVEL ?? 'none'; // silence by default
4748
env.OTEL_TRACES_SAMPLER = env.OTEL_TRACES_SAMPLER ?? 'parentbased_always_on';
4849
env.OTEL_TRACES_SAMPLER_ARG = env.OTEL_TRACES_SAMPLER_ARG ?? '1';
4950

@@ -99,8 +100,14 @@ export const initSDK = (config: SDKConfig) => {
99100
'@opentelemetry/instrumentation-fs': {
100101
enabled: false,
101102
},
103+
// FIXME: enable this once auto instrumentation is upgraded to v0.40.2
104+
'@opentelemetry/instrumentation-net': {
105+
enabled: false,
106+
},
102107
...config.instrumentations,
103108
}),
109+
// for fix: https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-net-v0.32.4
110+
new NetInstrumentation(),
104111
...(config.additionalInstrumentations ?? []),
105112
],
106113
});

yarn.lock

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1634,6 +1634,14 @@
16341634
"@opentelemetry/instrumentation" "^0.40.0"
16351635
"@opentelemetry/semantic-conventions" "^1.0.0"
16361636

1637+
"@opentelemetry/instrumentation-net@~0.32.4":
1638+
version "0.32.4"
1639+
resolved "https://registry.yarnpkg.com/@opentelemetry/instrumentation-net/-/instrumentation-net-0.32.4.tgz#edcfcad41f4b8ae75841ebfffaa7efdfc37ff536"
1640+
integrity sha512-sZUELN+pO73Mo2zXOt9pTrmwsVtf/WvOOjh+ItFYth4X5syOcHA192NvoEPLqIgWv0L5Iipm8M2SiWZiWm2X7w==
1641+
dependencies:
1642+
"@opentelemetry/instrumentation" "^0.45.1"
1643+
"@opentelemetry/semantic-conventions" "^1.0.0"
1644+
16371645
"@opentelemetry/instrumentation-pg@^0.35.3":
16381646
version "0.35.3"
16391647
resolved "https://registry.yarnpkg.com/@opentelemetry/instrumentation-pg/-/instrumentation-pg-0.35.3.tgz#47b29891e2be797a2148e699bb43094fdf33a281"
@@ -1752,6 +1760,17 @@
17521760
semver "^7.5.1"
17531761
shimmer "^1.2.1"
17541762

1763+
"@opentelemetry/instrumentation@^0.45.1":
1764+
version "0.45.1"
1765+
resolved "https://registry.yarnpkg.com/@opentelemetry/instrumentation/-/instrumentation-0.45.1.tgz#043ac90a889fae8a551c8d06e16be443984449af"
1766+
integrity sha512-V1Cr0g8hSg35lpW3G/GYVZurrhHrQZJdmP68WyJ83f1FDn3iru+/Vnlto9kiOSm7PHhW+pZGdb9Fbv+mkQ31CA==
1767+
dependencies:
1768+
"@types/shimmer" "^1.0.2"
1769+
import-in-the-middle "1.4.2"
1770+
require-in-the-middle "^7.1.1"
1771+
semver "^7.5.2"
1772+
shimmer "^1.2.1"
1773+
17551774
"@opentelemetry/[email protected]":
17561775
version "0.40.0"
17571776
resolved "https://registry.yarnpkg.com/@opentelemetry/otlp-exporter-base/-/otlp-exporter-base-0.40.0.tgz#34568717b86cfdc9743d4a7c43606a67118458b3"
@@ -7076,7 +7095,7 @@ semver@^6.0.0, semver@^6.3.0:
70767095
resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.0.tgz#ee0a64c8af5e8ceea67687b133761e1becbd1d3d"
70777096
integrity sha512-b39TBaTSfV6yBrapU89p5fKekE2m/NwnDocOVruQFS1/veMgdzuPcnOM34M6CwxW8jH/lxEa5rBoDeUwu5HHTw==
70787097

7079-
semver@^7.5.1:
7098+
semver@^7.5.1, semver@^7.5.2:
70807099
version "7.5.4"
70817100
resolved "https://registry.yarnpkg.com/semver/-/semver-7.5.4.tgz#483986ec4ed38e1c6c48c34894a9182dbff68a6e"
70827101
integrity sha512-1bCSESV6Pv+i21Hvpxp3Dx+pSD8lIPt8uVjRrxAUt/nbswYc+tK6Y2btiULjd4+fnq15PX+nqQDC7Oft7WkwcA==

0 commit comments

Comments
 (0)