Fix Infection tests #176
Merged
Fix Infection tests #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infection was "passing" only because the process was failing hard which indeeds counts as killing a mutant, but in this specific case this was not for the right reasons. I investigated and managed to apply the right patches to make it work. The e2e tests also no runs the not prefixed Infection and compares the result with the prefixed one as they should be identical.
theofidry
force-pushed
the
bugfix/infection
branch
from
2bcae7a to
178e7a8
Compare
Member
Author
|
@borNfreee with it it's ready to go |
|
Awesome 👍 We will definitely use your work soon after I merge infection/infection#67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infection was "passing" only because the process was failing hard which indeeds counts as killing a mutant, but in this specific case this was not for the right reasons.
I investigated and managed to apply the right patches to make it work. The e2e tests also no runs the not prefixed Infection and compares the result with the prefixed one as they should be identical.