Use BetterReflection for global classes #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
force-pushed
the
feature/better-reflection
branch
from
94f8c22 to
e5c571f
Compare
Closed
theofidry
changed the title
This was referenced Jan 26, 2018
theofidry
force-pushed
the
feature/better-reflection
branch
2 times, most recently
from
8826fbb to
d735b41
Compare
theofidry
commented
Feb 14, 2018
Member
Author
theofidry
left a comment
theofidry
left a comment
There was a problem hiding this comment.
I think I went a bit too far in that PR as a few behavioural changes could have been done in other PRs to make it simpler.
However as it stands now too many tests would require to be updated so the overhead would be quite significant.
I think it's better to cleanup this PR and continue the remaining work in other PRs but not worth to rework this PR to simplify it by breaking it down in several PRs which would have a lot of conflicts.
TODO-roave
Outdated
| @@ -0,0 +1,112 @@ | |||
| // vendor/roave/better-reflection/src/SourceLocator/Ast/Locator.php | |||
Member
Author
There was a problem hiding this comment.
TODO: this should be a patch for roave/better-reflection
tests/Scoper/PhpScoperTest.php
Outdated
| $whitelister = function (string $className) { | ||
| return 'AppKernel' === $className; | ||
| }; | ||
| $nonInternalReflectionProphecy = $this->prophesize(ReflectionClass::class); |
| if (null === $namespace->name && $this->hasWhitelistedNode([$namespace])) { | ||
| return true; | ||
| } | ||
| // if (null === $namespace->name && $this->hasWhitelistedNode([$namespace])) { |
| || AppendParentNode::hasParent($node) | ||
| ) ? $node : $this->wrapNamespace($node); | ||
| } | ||
| // |
.TODO
Outdated
| @@ -0,0 +1,17 @@ | |||
| Right now whitelisted class works as follow: | |||
Member
Author
There was a problem hiding this comment.
Should be transformed into several issues rather than this file
This was referenced Feb 15, 2018
theofidry
force-pushed
the
feature/better-reflection
branch
from
5577270 to
02ef70e
Compare
Member
Author
|
The e2e tests are not passing due to #152 |
This was referenced Feb 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of not touching the global classes at all and prefix them only when explicitly specified, we can prefix them if they are not internal. We could then get rid of the global whitelist and allow the whitelist for classes belonging to the global namespace.
Current status: did a replacement and updating the tests; need more refactoring and checking the list above