composer.json is preffixed but also empty autoload psr-4 section is added

[TomasVotruba]

Original

File /vendor/latte/latte/composer.json

	"autoload": {
		"classmap": ["src/"]
	},

Prefixed

    "autoload": {
        "classmap": [
            "src\/"
        ],
        "psr-4": []
    },

Related to: rectorphp/rector#319

[theofidry]

That causes an issue? I wouldn't have suspected that :o

[TomasVotruba]

It's not cause, just bug that might be related.

[TomasVotruba]

I found that

composer dump  

handles only dependencies of root composer.json, so it skips /vendor :)

[theofidry]

yeah. I added the vendor composer.json files but that unnecessary (I forgot about that). What it actually needs is the vendor/composer/installed.json file

[TomasVotruba]

That might be the case, but still when I delete /vendor/autoload and run composer dump in root directory, it still skips /vendor

I'll investigate, give me a sec.

[theofidry]

You lost me there: if you do composer dump then Composer looks for getcwd().'/vendor/composer/installed.json file and dump the autoloader from that no? (not sure about your leading / but just in case, the composer dump you must do in your case is composer dump-autoload -d=build/rector or something like that)

[TomasVotruba]

So looks like this vendor/composer/installed.json works, thanks 👍 👏

In the meantime I got completelly new error - maybe you've met it already?

PHP Fatal error:  Uncaught Error: Call to undefined function KevinGH\Box\register_aliases() in /var/www/Rector/vendor/humbug/box/bin/box:28
Stack trace:
#0 {main}
  thrown in /var/www/Rector/vendor/humbug/box/bin/box on line 28

[theofidry]

Try to update your deps again, that function no longer exists (it has been renamed)

[TomasVotruba]

Ha, I needed to delete not only /vendor-bin, but also /vendor/bin/box.

Composer doesn't update those bin files. Build command works afterwards 👍

[TomasVotruba]

It fails the extra space / shebang again

PHP Fatal error:  Namespace declaration statement has to be the very first statement or after any declare call in the script in phar:///var/www/Rector/rector.phar/bin/rector on line 3

Work in progres...

[TomasVotruba]

Removing shebang works and I can still run it like ./rector.phar.

I got now error with autoloading, probably Finder in scoper.inc.php that just need bit tuning. Errors I like 👍 I will continue tomorrow.

There should be option to remove the shebang on phar file build.

[TomasVotruba]

Ok, so it's .yml related error in this package:

PHP Fatal error:  Uncaught PhpScoper5a8b08645a07f\Symfony\Component\DependencyInjection\Exception\RuntimeException: Invalid service "SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilder": class "SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilder" does not exist. in phar:///var/www/Rector/rector.phar/vendor/symfony/dependency-injection/Compiler/AbstractRecursivePass.php:109

services.yml remains untouched

# services.yml
services:
    _defaults:
        autowire: true

    Rector\ConsoleDiffer\:
        resource: ..

    SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilder:
        arguments:
            $options:
                'fromFile': 'Original'
                'toFile': 'New'

    SebastianBergmann\Diff\Differ:
        arguments:
            - '@SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilder'

Expected

# services.yml
services:
    _defaults:
        autowire: true

    PhpScoperPrefix\Rector\ConsoleDiffer\:
        resource: ..

    PhpScoperPrefix\SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilder:
        arguments:
            $options:
                'fromFile': 'Original'
                'toFile': 'New'

    PhpScoperPrefix\SebastianBergmann\Diff\Differ:
        arguments:
            - '@PhpScoperPrefix\SebastianBergmann\Diff\Output\StrictUnifiedDiffOutputBuilder'

[theofidry]

You can remove the shebang by using the config "shebang": null.

Thanks for looking into this. I realise it's a bit rough on the edges, but I can't free enough time to tune it fast enough :(

[theofidry]

Ha, indeed it's gonna be a funny one... how to scope YAML files. I have to think of that :/

[theofidry]

Do you reckon giving a list of YAML files (via a new finder config) would work?

'resources-finder' => [
    'symfony' => [
        // ...Finder instances
    ]
]