Skip to content

Conversation

@sergiopaniego
Copy link
Member

What does this PR do?

Following this PR that deprecates torch_dtype in favor of dtype, this PR introduces the same change to trl.

Legacy support for torch_dtype is still provided in to model_config.py but deprecated in a future version.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@qgallouedec @kashif

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec
Copy link
Member

Thanks!
This requires bumping the min transformers version to 4.56

@qgallouedec
Copy link
Member

You can safely ignore the failing CI, see huggingface/transformers#40668

Copy link
Member

@qgallouedec qgallouedec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qgallouedec qgallouedec changed the title torch_dype to dtype everywhere 📏 torch_dype to dtype everywhere Sep 3, 2025
@qgallouedec qgallouedec merged commit 208e9f7 into main Sep 3, 2025
9 of 11 checks passed
@qgallouedec qgallouedec deleted the dtype-default branch September 3, 2025 21:45
SamY724 pushed a commit to SamY724/trl that referenced this pull request Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants