Skip to content

Warn the user about max_len being on the path to be deprecated. #4528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2020
Merged

Warn the user about max_len being on the path to be deprecated. #4528

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a04520d
Warn the user about max_len being on the path to be deprecated.
mfuntowicz May 22, 2020
71c46cc
Ensure better backward compatibility when max_len is provided to a to…
mfuntowicz May 22, 2020
28a9828
Make sure to override the parameter and not the actual instance value.
mfuntowicz May 22, 2020
e6abd15
Format & quality
mfuntowicz May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/transformers/tokenization_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import operator
import os
import re
import warnings
from collections import UserDict, defaultdict
from contextlib import contextmanager
from typing import Any, Dict, List, NamedTuple, Optional, Sequence, Tuple, Union
Expand Down Expand Up @@ -822,7 +823,14 @@ def __init__(self, model_max_length=None, **kwargs):
super().__init__(**kwargs)

# For backward compatibility we fallback to set model_max_length from max_len if provided
model_max_length = model_max_length if model_max_length is not None else kwargs.pop("max_len", None)
if "max_len" in kwargs:
warnings.warn(
"Parameter max_len is deprecated and will be removed in a future release. "
"Use model_max_length instead.",
category=FutureWarning,
)

model_max_length = kwargs.pop("max_len")
self.model_max_length = model_max_length if model_max_length is not None else VERY_LARGE_INTEGER

# Padding side is right by default and overridden in subclasses. If specified in the kwargs, it is changed.
Expand Down