Skip to content

Warn the user about max_len being on the path to be deprecated. #4528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 22, 2020
Merged

Warn the user about max_len being on the path to be deprecated. #4528

merged 4 commits into from
May 22, 2020

Conversation

@mfuntowicz
Copy link
Member

@mfuntowicz mfuntowicz commented May 22, 2020 •
edited
Loading

Makes it clear the parameter model_max_length is preferred over max_len by writting a warning to the logger.

#4527

LysandreJik
LysandreJik approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mfuntowicz

@LysandreJik LysandreJik merged commit 996f393 into master May 22, 2020
@LysandreJik LysandreJik deleted the max_len_depreciation_warning branch May 22, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

@thomwolf thomwolf Awaiting requested review from thomwolf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfuntowicz @LysandreJik