Nit

Author: romitjain

src/peft/tuners/lora/model.py

@@ -261,16 +261,9 @@ def _create_and_replace(
                 # adding an additional adapter: it is not automatically trainable
                 new_module.requires_grad_(False)
 
-            self._replace_module(
-                parent=parent,
-                child_name=target_name,
-                new_module=new_module,
-                child=target,
-                is_tied=is_tied,
-                adapter_name=adapter_name,
-            )
+            self._replace_module(parent=parent, child_name=target_name, new_module=new_module, child=target)
 
-    def _replace_module(self, parent, child_name, new_module, child, is_tied, adapter_name):
+    def _replace_module(self, parent, child_name, new_module, child):
         # override in LoraModel to handle quantized weights properly
 
         setattr(parent, child_name, new_module)

tests/test_initialization.py

@@ -4837,9 +4837,6 @@ def prepare_inputs_for_generation(self):
             def get_input_embeddings(self):
                 return self.model.embed_tokens
 
-            def get_output_embeddings(self):
-                return self.lm_head
-
         return CausalLM().eval().to(self.torch_device)
 
     @pytest.mark.parametrize("layer", ["lm_head", "embed_tokens", ["lm_head", "embed_tokens"]])