-
Notifications
You must be signed in to change notification settings - Fork 3k
Use HF_HUB_OFFLINE instead of HF_DATASETS_OFFLINE
#6968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice ! Feel free to fix the code style :)
btw we're doing a release today, but no need to include this PR in it IMO, we can merge this one tomorrow
Could you also update the mentions of HF_DATASETS_OFFLINE in the docs ?
|
Oops, sorry for the style issue. Fixed in a4e2b28. Regarding docs, I can't find mentions of |
Show benchmarksPyArrow==8.0.0 Show updated benchmarks!Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
Show updated benchmarks!Benchmark: benchmark_array_xd.json
Benchmark: benchmark_getitem_100B.json
Benchmark: benchmark_indices_mapping.json
Benchmark: benchmark_iterating.json
Benchmark: benchmark_map_filter.json
|

To use
datasetsoffline, one can use theHF_DATASETS_OFFLINEenvironment variable. This PR makesHF_HUB_OFFLINEthe recommended environment variable for offline training. Goal is to be more consistent with the rest of HF ecosystem and have a single config value to set.The changes are backward-compatible meaning that:
HF_DATASETS_OFFLINEenvironment is still taken into account, though not documenteddatasets.config.HF_DATASETS_OFFLINEstill exists, though it is not used anymore (in favor ofdatasets.config.HF_HUB_OFFLINE)Note: it might break things in downstream libraries if they were monkeypatching
datasets.config.HF_DATASETS_OFFLINEin their CI tests (for instance). Not much of a problem IMO.