-
Notifications
You must be signed in to change notification settings - Fork 3k
Using a registry instead of calling globals for fetching feature types #6727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lhoestq
merged 11 commits into
huggingface:main
from
psmyth94:fetch-features-from-registry
Mar 13, 2024
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
731ca73
Add a registry instead of calling globals for fetching feature types
HuggingFaceDocBuilder dd982cb
Refactor feature registration function
HuggingFaceDocBuilder eabf6a9
Merge branch 'main' into fetch-features-from-registry
psmyth94 8fd0c5b
Add feature type registry lookup first before global lookup
HuggingFaceDocBuilder f853826
Merge branch 'fetch-features-from-registry' of github.com:psmyth94/da…
HuggingFaceDocBuilder 3f6fd37
Add experimental feature registration
HuggingFaceDocBuilder 67705da
Reorder imports in features.py
HuggingFaceDocBuilder 99cad86
Reorder imports in features.py
HuggingFaceDocBuilder a52c609
Merge branch 'fetch-features-from-registry' of github.com:psmyth94/da…
HuggingFaceDocBuilder b7abb24
Merge branch 'main' into fetch-features-from-registry
lhoestq dabfae7
Merge branch 'main' into fetch-features-from-registry
psmyth94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.