Skip to content

Add trust_remote_code argument #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 28, 2023
Merged

Add trust_remote_code argument #6429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d99b822
add trust_remote_code
lhoestq Nov 16, 2023
a994c00
rename env variable to HF_DATASETS_DEFAULT_TRUST_REMOTE_CODE
lhoestq Nov 24, 2023
2bb0b21
add FutureWarning
lhoestq Nov 24, 2023
b0c30fa
fix docstring
lhoestq Nov 24, 2023
1bf7408
actually HF_DATASETS_TRUST_REMOTE_CODE_DEFAULT
lhoestq Nov 24, 2023
c5fbd68
fix
lhoestq Nov 24, 2023
6e17dd8
add tests
lhoestq Nov 24, 2023
f71e5d5
test_resolve_trust_remote_code
lhoestq Nov 24, 2023
72880aa
test_resolve_trust_remote_code_future
lhoestq Nov 24, 2023
5394939
docs
lhoestq Nov 24, 2023
33dc51f
Apply suggestions from code review
lhoestq Nov 27, 2023
1228d83
mario's comments
lhoestq Nov 27, 2023
9499908
remove DEFAULT
lhoestq Nov 27, 2023
495bc04
fix shard number
lhoestq Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/datasets/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import os
import platform
from pathlib import Path
from typing import Optional

from packaging import version

Expand Down Expand Up @@ -31,7 +32,9 @@

# General environment variables accepted values for booleans
ENV_VARS_TRUE_VALUES = {"1", "ON", "YES", "TRUE"}
ENV_VARS_FALSE_VALUES = {"0", "OFF", "NO", "FALSE"}
ENV_VARS_TRUE_AND_AUTO_VALUES = ENV_VARS_TRUE_VALUES.union({"AUTO"})
ENV_VARS_FALSE_AND_AUTO_VALUES = ENV_VARS_FALSE_VALUES.union({"AUTO"})


# Imports
Expand Down Expand Up @@ -170,6 +173,16 @@
os.environ.get("HF_UPDATE_DOWNLOAD_COUNTS", "AUTO").upper() in ENV_VARS_TRUE_AND_AUTO_VALUES
)

# Remote dataset scripts support
TRUST_REMOTE_CODE: Optional[bool] = (
True
if os.environ.get("HF_TRUST_REMOTE_CODE", "AUTO").upper() in ENV_VARS_TRUE_AND_AUTO_VALUES
else False
if os.environ.get("HF_TRUST_REMOTE_CODE", "AUTO").upper() in ENV_VARS_FALSE_VALUES
else None
)
TIME_OUT_REMOTE_CODE = 15

# Batch size constants. For more info, see:
# https://github.com/apache/arrow/blob/master/docs/source/cpp/arrays.rst#size-limitations-and-recommendations)
DEFAULT_MAX_BATCH_SIZE = 1000
Expand Down
Loading