Skip to content

Improve error message for missing function parameters #6232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Improve error message for missing function parameters #6232

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
251e419
Improve error message for missing function parameters
Sep 11, 2023
2c18dc3
Replace __name__ with __qualname__
mariosasko Sep 13, 2023
4c09e16
Merge branch 'main' into fixes-fingerprint-error-fstrings
mariosasko Sep 13, 2023
facd60f
Revert
mariosasko Sep 13, 2023
6db0388
Merge branch 'main' into fixes-fingerprint-error-fstrings
mariosasko Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datasets/fingerprint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ def fingerprint_transform(

def _fingerprint(func):
if not inplace and not all(name in func.__code__.co_varnames for name in fingerprint_names):
raise ValueError("function {func} is missing parameters {fingerprint_names} in signature")
raise ValueError(f"function {func} is missing parameters {fingerprint_names} in signature")

if randomized_function: # randomized function have seed and generator parameters
if "seed" not in func.__code__.co_varnames:
Expand Down