Skip to content

Conversation

@sayakpaul
Copy link
Member

Closes #5182

Comment on lines +157 to +159
To learn how to leverage parts of 🤗 datasets end-to-end for training an object detection model, refer to
[this notebook](https://nbviewer.org/github/NielsRogge/Transformers-Tutorials/blob/master/YOLOS/Fine_tuning_YOLOS_for_object_detection_on_custom_dataset_%28balloon%29.ipynb).

Copy link
Member Author

@sayakpaul sayakpaul Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NielsRogge is there a plan to leverage more parts of datasets in this notebook? I have gone through the notebook and it felt like it was necessary to leverage torchvision in some parts to get the data pipeline ready.

Let me know.

@sayakpaul sayakpaul self-assigned this Nov 2, 2022
@sayakpaul sayakpaul added the enhancement New feature or request label Nov 2, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 2, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@nateraw nateraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer both be GitHub links, but that's just my opinion. Other than that, LGTM

@sayakpaul
Copy link
Member Author

@nateraw I guess the failing test is unrelated.

@nateraw
Copy link
Contributor

nateraw commented Nov 2, 2022

@sayakpaul Yea failures are unrelated.

@sayakpaul
Copy link
Member Author

Alright. Will wait for @osanseviero's take and then merge.

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments that could help here, but otherwise LGTM!

@osanseviero
Copy link
Contributor

FYI @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for connecting all these resources!

@sayakpaul
Copy link
Member Author

@osanseviero @stevhliu @nateraw thank you for your comments. Acted on them.

Copy link
Contributor

@nateraw nateraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sayakpaul
Copy link
Member Author

Thanks! Can I merge? Or should we wait for approvals from the others?

@nateraw
Copy link
Contributor

nateraw commented Nov 3, 2022

Since @stevhliu approved as well, I think you're good to go

@sayakpaul
Copy link
Member Author

Alright!

Merging as a Member for the first time 🫀

@sayakpaul sayakpaul merged commit 2cfb5d5 into huggingface:main Nov 3, 2022
@sayakpaul sayakpaul deleted the add/notebook-links branch November 3, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add notebook / other resource links to the task-specific data loading guides

5 participants