Skip to content

Fix CI require beam #5168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Fix CI require beam #5168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
616d3da
Fix require beam
albertvillanova Oct 26, 2022
806dfb3
Refactor require_beam
albertvillanova Oct 26, 2022
1b9c17c
Fix missing require_beam
albertvillanova Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/test_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,6 +1068,7 @@ def test_arrow_based_builder_download_and_prepare_as_sharded_parquet_with_max_sh
assert sum(parquet_file.metadata.num_rows for parquet_file in parquet_files) == 100


@require_beam
def test_beam_based_builder_download_and_prepare_as_parquet(tmp_path):
builder = DummyBeamBasedBuilder(cache_dir=tmp_path, beam_runner="DirectRunner")
builder.download_and_prepare(file_format="parquet")
Expand Down
13 changes: 2 additions & 11 deletions tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,8 @@ def parse_flag_from_env(key, default=False):
reason="test requires torchaudio>=0.12",
)


def require_beam(test_case):
"""
Decorator marking a test that requires Apache Beam.

These tests are skipped when Apache Beam isn't installed.

"""
if not config.TORCH_AVAILABLE:
test_case = unittest.skip("test requires PyTorch")(test_case)
return test_case
# Beam
require_beam = pytest.mark.skipif(not config.BEAM_AVAILABLE, reason="test requires apache-beam")


def require_faiss(test_case):
Expand Down