Add ffmpeg4 installation instructions in warnings #5167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Member
|
To make it warn only once, feel free to use a global counter in python - and if the warning has already been done, you don't do it again |
Co-authored-by: Quentin Lhoest <[email protected]>
lhoestq
approved these changes
Oct 27, 2022
Co-authored-by: Quentin Lhoest <[email protected]>
Contributor
Author
nice!! thank you!
Yes, more warnings is better then no warnings.... I'll merge when the CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instructions on how to install
ffmpeg=4on Linux (relevant for Colab users).Looks pretty ugly because I didn't find a way to check
ffmpegversion from python (withoutsubprocess.call();ctypes.util.find_librarydoesn't work`), so the warning is raised on each decoding. Any suggestions on how to make it look nice are welcome!This is how it looks on Colab:
