Skip to content

fsspec lock reset in multiprocessing #5159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2022
Merged

fsspec lock reset in multiprocessing #5159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e471bae
fsspec lock reset
lhoestq Oct 25, 2022
794ce3a
style
lhoestq Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/datasets/formatting/dataset_wrappers/torch_iterable_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import threading

import fsspec.asyn
import torch

Expand All @@ -15,8 +17,13 @@ def _set_fsspec_for_multiprocess() -> None:
Only required for fsspec >= 0.9.0
See https://github.com/fsspec/gcsfs/issues/379
"""
fsspec.asyn.iothread[0] = None
fsspec.asyn.loop[0] = None
if hasattr(fsspec.asyn, "reset_lock"):
# for future fsspec>2022.05.0
fsspec.asyn.reset_lock()
else:
fsspec.asyn.iothread[0] = None
fsspec.asyn.loop[0] = None
fsspec.asyn.lock = threading.Lock()
Copy link
Member Author

@lhoestq lhoestq Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, we were not resetting the lock correctly apparently - I added this line anyway



class TorchIterableDataset(IterableDataset, torch.utils.data.IterableDataset):
Expand Down