Skip to content

TextConfig: added "errors" #5155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2022
Merged

TextConfig: added "errors" #5155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e74302
TextConfig: added "errors"
NightMachinery Oct 24, 2022
c6be620
Update src/datasets/packaged_modules/text/text.py
lhoestq Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/datasets/packaged_modules/text/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class TextConfig(datasets.BuilderConfig):

features: Optional[datasets.Features] = None
encoding: str = "utf-8"
errors: Optional[str] = None
chunksize: int = 10 << 20 # 10MB
keep_linebreaks: bool = False
sample_by: str = "line"
Expand Down Expand Up @@ -70,7 +71,7 @@ def _generate_tables(self, files):
pa_table_names = list(self.config.features) if self.config.features is not None else ["text"]
for file_idx, file in enumerate(itertools.chain.from_iterable(files)):
# open in text mode, by default translates universal newlines ("\n", "\r\n" and "\r") into "\n"
with open(file, encoding=self.config.encoding) as f:
with open(file, encoding=self.config.encoding, errors=self.config.errors) as f:
if self.config.sample_by == "line":
batch_idx = 0
while True:
Expand Down