Skip to content

Conversation

@NightMachinery
Copy link
Contributor

@NightMachinery NightMachinery commented Oct 24, 2022

This patch adds the ability to set the errors option of open for loading text datasets. I needed it because some data I had scraped had bad bytes in it, so I needed errors='ignore'.

@NightMachinery NightMachinery marked this pull request as ready for review October 24, 2022 19:02
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 27, 2022

The documentation is not available anymore as the PR was closed or merged.

@lhoestq
Copy link
Member

lhoestq commented Oct 27, 2022

Thanks for adding this ! You can fix the CI by formatting your code using the make style command :)

@NightMachinery
Copy link
Contributor Author

@lhoestq commented on Oct 27, 2022, 4:08 PM GMT+3:30:

Thanks for adding this ! You can fix the CI by formatting your code using the make style command :)

I ran this and force pushed the changes.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this argument :)

@lhoestq lhoestq merged commit 87e5b80 into huggingface:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants