-
Notifications
You must be signed in to change notification settings - Fork 3k
Make filename matching more robust #5128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make filename matching more robust #5128
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
mariosasko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think we should also modify one of the metadata files in the folder_based_builder tests to make sure "./" is ignored now in the file_name
src/datasets/packaged_modules/folder_based_builder/folder_based_builder.py
Outdated
Show resolved
Hide resolved
src/datasets/packaged_modules/folder_based_builder/folder_based_builder.py
Outdated
Show resolved
Hide resolved
@mariosasko what do you mean here? I'm not sure which metadata file I should modify here |
|
You can modify this line for instance:
|
mariosasko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks all good now!
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! LGTM :)
Fix #5046