Install tensorflow-macos dependency conditionally #5124
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
| "s3fs>=2021.11.1", # aligned with fsspec[http]>=2021.11.1 | ||
| "tensorflow>=2.3,!=2.6.0,!=2.6.1", | ||
| "tensorflow>=2.3,!=2.6.0,!=2.6.1; sys_platform != 'darwin' or platform_machine != 'arm64'", | ||
| "tensorflow-macos; sys_platform == 'darwin' and platform_machine == 'arm64'", |
There was a problem hiding this comment.
BTW I think and platform_machine == 'arm64'" is not needed, as I was able to install tensorflow-macos on my MacOS with an Intel chip
$ sysctl -a | grep Intel
machdep.cpu.vendor: GenuineIntel
machdep.cpu.brand_string: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
But maybe it's better to limit the exception cases and only use the fork for arm64.
There was a problem hiding this comment.
@severo I'm not an expert on this subject. But it appears they recommend tensorflow-macos also for Intel x86-64: https://developer.apple.com/metal/tensorflow-plugin/
So you think I can safely remove and platform_machine == 'arm64'? Or better keeping to reduce the scope?
There was a problem hiding this comment.
I really don't know, I just wanted to share my recent experience with the same problem, and use the same solution if you opt for a reduced scope.
* refactor: 💡 rename error to ensure it's clear it's an error.Also remove an unused error * chore: 🤖 align with the datasets library for mac install see huggingface/datasets#5124 * feat: 🎸 update docker images
* refactor: 💡 rename error to ensure it's clear it's an error.Also remove an unused error * chore: 🤖 align with the datasets library for mac install see huggingface/datasets#5124 * feat: 🎸 update docker images
3 participants
Fix #5118.