added from_generator method to IterableDataset class. #5052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
mariosasko
reviewed
Oct 3, 2022
Collaborator
mariosasko
left a comment
mariosasko
left a comment
There was a problem hiding this comment.
Great job, thanks!
Besides my comment below, we also need a test (let me know if you need help with that), and then we can merge.
Collaborator
|
I added a test and moved the @hamid-vakilzadeh Are you OK with these changes? |
Contributor
Author
|
@mariosasko these all look great! Thanks for the updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This resolves issues #4988.
I added a method
from_generatorto classIterableDataset.I modified the
readmethod of input stream generator to also return Iterable_dataset.