Revert task removal in folder-based builders #5051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
lhoestq
approved these changes
Sep 30, 2022
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Cool thanks :)
I agree it would be nice to use the train_eval_index metadata in the future
lhoestq
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Add AudioClassification task * Add classification task to folder based builders * Fix tests * Minor fix * Minor fix again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the removal of
task_templatesin the folder-based builders. I also added theAudioClassifactiontask for consistency.This is needed to fix huggingface/transformers#19177.
I think we should soon deprecate and remove the current task API (and investigate if it's possible to integrate the
train eval indexAPI), but we need to update the Transformers examples before that so we don't break them.cc @NielsRogge