Add test-datasets CI job #4952
Closed
Add test-datasets CI job #4952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
Member
Author
|
Closing this one since the dataset scripts will be removed in #4974 |
polinaeterna
pushed a commit
to stevhliu/datasets
that referenced
this pull request
Sep 20, 2022
lhoestq
added a commit
that referenced
this pull request
Sep 21, 2022
* 📝 add docs for creating audio dataset * 🖍 small edits, encourage TAR archives more * 🖍 apply polina feedbacks * audiofolder and metadata first * oops metadata first also in audio load * replace vivos with librivox indonesia, describe streaming in more detail * taking over the PR * check if i can push to other's fork don't look at this * git back vivos as main example, simplify instructions. add librivox-indonesia as an advanced example * Apply some suggestions from code review Co-authored-by: Quentin Lhoest <[email protected]> * Update docs/source/audio_dataset_repo.mdx Co-authored-by: Quentin Lhoest <[email protected]> * fix something i don't remember what, integrate changes from #4925 * integrate #4952 to image docs too * rename audio and image datasets guides consistently (to audio/image_dataset.mdx) * remove outdated doc * fix audio guide name * fix link + minor changes Co-authored-by: Quentin Lhoest <[email protected]> Co-authored-by: Quentin Lhoest <[email protected]> Co-authored-by: polinaeterna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid having too many conflicts in the datasets and metrics dependencies I split the CI into test and test-catalog
test does the test of the core of the
datasetslib, while test-catalog tests the datasets scripts and metrics scriptsThis also makes
pip install -e .[dev]much smaller for developersWDYT @albertvillanova ?