Skip to content

Conversation

@stevhliu
Copy link
Member

The Markdown link fails to render if it is in the same line as the <span>. This PR implements @mishig25's fix by using <a href=" "> instead.

Screen Shot 2022-07-20 at 3 53 05 PM

@stevhliu stevhliu requested review from lhoestq and mishig25 July 20, 2022 22:57
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 20, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stevhliu and @mishig25.

@albertvillanova albertvillanova merged commit 5b2dcf3 into huggingface:main Jul 21, 2022
@stevhliu stevhliu deleted the fix-html-link branch July 21, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants