Skip to content

Conversation

@albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jul 20, 2022

Previously, fixture modules hub_fixtures and s3_fixtures:

  • were both at the root test directory
  • were imported using import *
    • as a side effect, the modules os and pytest were imported from s3_fixtures into conftest

This PR:

  • puts both fixture modules in a dedicated directory fixtures
  • renames both to: fixtures.hub and fixtures.s3
  • imports them into conftest as plugins, using the pytest_plugins: this avoids the import *
  • additionally creates a new fixture module fixtures.files with all file-related fixtures

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 20, 2022

The documentation is not available anymore as the PR was closed or merged.

@albertvillanova albertvillanova force-pushed the fix-conftest-fixtures branch from 8beae88 to 6a0fe3e Compare July 20, 2022 21:22
@albertvillanova albertvillanova merged commit 4e4222f into huggingface:main Jul 21, 2022
@albertvillanova albertvillanova deleted the fix-conftest-fixtures branch July 21, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants