Skip to content

Conversation

@mishig25
Copy link

@mishig25 mishig25 commented Jul 20, 2022

href="/docs/datasets/quickstart#audio" implicitly goes to href="/docs/datasets/{$LATEST_STABLE_VERSION}/quickstart#audio". Therefore, https://huggingface.co/docs/datasets/quickstart#audio #audio hashlink does not work since the new docs were not added to v2.3.2 (LATEST_STABLE_VERSION)

to preserve the version, it should be just href="#audio", which will implicilty go to curren_page + #audio element

@mishig25 mishig25 requested review from lhoestq and stevhliu July 20, 2022 10:08
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 20, 2022

The documentation is not available anymore as the PR was closed or merged.

@mishig25 mishig25 changed the title Fix same-page haslinks Docs: Fix same-page haslinks Jul 20, 2022
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation and fixing! 🤗

@mishig25 mishig25 merged commit 578e6ee into main Jul 20, 2022
@mishig25 mishig25 deleted the mishig25-patch-2 branch July 20, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants