Skip to content

Conversation

@albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jul 11, 2022

Fix partially #3541, fix #4670.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 11, 2022

The documentation is not available anymore as the PR was closed or merged.

@mariosasko
Copy link
Collaborator

Cool! Can you please remove Fix #3541 from the description as this PR doesn't add support for streaming/iter_archive, so it only partially addresses the issue?

Side note:
I think we can use libarchive (libarchive-c is a Python package with the bindings) for streaming 7z archives. The only issue with this lib is that it's tricky to install on Windows/Mac.

@albertvillanova albertvillanova changed the title Support 7-zip compressed data files Support extract 7-zip compressed data files Jul 15, 2022
@albertvillanova albertvillanova merged commit 44d48a2 into huggingface:main Jul 15, 2022
@albertvillanova albertvillanova deleted the fix-3541 branch July 15, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't extract files from .7z zipfile using download_and_extract

3 participants