Skip to content

Conversation

@lhoestq
Copy link
Member

@lhoestq lhoestq commented Jul 6, 2022

This PR renames mentions of "master" by "main" in the code base for several cases:

  • set the default dataset script version to "main" if the local installation of datasets is a dev installation
  • update URLs to this github repository to use "main"
  • update the DVC benchmark
  • update the github workflows
  • update docstrings
  • update tests to compare the changes in dataset cards against "main"

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jul 6, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This was a pending task to do for too long...

I guess everything is right. The validation is a bit blindly. This is not a task we do often...

Do you know if some other projects may have our default branch name hard-coded?

@lhoestq
Copy link
Member Author

lhoestq commented Jul 6, 2022

All the mentions I found on google were simple URLs that will be redirected, so it's fine. I also checked the spaces and we should be good:

@lhoestq
Copy link
Member Author

lhoestq commented Jul 6, 2022

Ok let's rename the branch, and then we can merge this PR

@lhoestq lhoestq marked this pull request as ready for review July 6, 2022 15:22
@lhoestq lhoestq merged commit d76599b into main Jul 6, 2022
@lhoestq lhoestq deleted the rename-master-to-main-1 branch July 6, 2022 15:25
@albertvillanova albertvillanova linked an issue Jul 6, 2022 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename repo default branch to main

4 participants