-
Notifications
You must be signed in to change notification settings - Fork 3k
Align more metadata with other repo types (models,spaces) #4607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
I just set a default value (None) for the deprecated licenses and languages fields, which should fix most of the CI failures. Note that the CI should still be red because you edited many dataset cards and they're still missing some content - but this is unrelated to this PR so we can ignore these failures |
|
thanks so much @lhoestq !! |
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks all good thanks :)
The 345 CI failures are all unrelated to this PR (bad/missing tags or content in dataset cards)
Can you check that it looks good to you @albertvillanova ?
albertvillanova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @julien-c, really necessary to align as much as possible all projects.
Indeed I had already noticed that when creating a new dataset using the Hub UI, if a license was chosen from the dropdown menu, the generated tag was license instead of licenses. This fixes this issue as well.
|
There's also a follow-up PR to this one, in #4613 – I would suggest to merge all of them at the same time and hope not too many things are broken 🙀 🙀 |
|
Alright merging this one now, let's see how broken things get |
see also associated PR on the
datasets-taggingSpace: https://huggingface.co/spaces/huggingface/datasets-tagging/discussions/2 (to merge after this one is merged)