Skip to content

Conversation

@julien-c
Copy link
Member

see also associated PR on the datasets-tagging Space: https://huggingface.co/spaces/huggingface/datasets-tagging/discussions/2 (to merge after this one is merged)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 30, 2022

The documentation is not available anymore as the PR was closed or merged.

@lhoestq
Copy link
Member

lhoestq commented Jun 30, 2022

I just set a default value (None) for the deprecated licenses and languages fields, which should fix most of the CI failures.

Note that the CI should still be red because you edited many dataset cards and they're still missing some content - but this is unrelated to this PR so we can ignore these failures

@julien-c
Copy link
Member Author

thanks so much @lhoestq !!

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks all good thanks :)

The 345 CI failures are all unrelated to this PR (bad/missing tags or content in dataset cards)

Can you check that it looks good to you @albertvillanova ?

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @julien-c, really necessary to align as much as possible all projects.

Indeed I had already noticed that when creating a new dataset using the Hub UI, if a license was chosen from the dropdown menu, the generated tag was license instead of licenses. This fixes this issue as well.

@julien-c
Copy link
Member Author

julien-c commented Jul 1, 2022

There's also a follow-up PR to this one, in #4613 – I would suggest to merge all of them at the same time and hope not too many things are broken 🙀 🙀

@lhoestq
Copy link
Member

lhoestq commented Jul 1, 2022

Alright merging this one now, let's see how broken things get

@lhoestq lhoestq merged commit a519296 into master Jul 1, 2022
@lhoestq lhoestq deleted the metadata-update-v1 branch July 1, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants