Skip to content

Conversation

@lhoestq
Copy link
Member

@lhoestq lhoestq commented Jun 13, 2022

When a depenency is missing for a dataset script, an ImportError message is shown, with a tip to install the missing dependencies. This message is not ideal at the moment: it may show duplicate dependencies, and is not very readable.

I improved it from

ImportError: To be able to use bigbench, you need to install the following dependencies['bigbench', 'bigbench', 'bigbench', 'bigbench'] using 'pip install "bigbench @ https://storage.googleapis.com/public_research_data/bigbench/bigbench-0.0.1.tar.gz" bigbench bigbench bigbench' for instance'

to

ImportError: To be able to use bigbench, you need to install the following dependency: bigbench.
Please install it using 'pip install "bigbench @ https://storage.googleapis.com/public_research_data/bigbench/bigbench-0.0.1.tar.gz"' for instance'

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 13, 2022

The documentation is not available anymore as the PR was closed or merged.

@lhoestq
Copy link
Member Author

lhoestq commented Jun 13, 2022

Discussed offline with @mariosasko, merging :)

@lhoestq lhoestq merged commit ee3f3be into master Jun 13, 2022
@lhoestq lhoestq deleted the better-importerror-message branch June 13, 2022 13:50
@thesofakillers
Copy link

Fwiw, i think this same issue is occurring on the datasets website page, where preview isn't available due to the bigbench import error

@lhoestq
Copy link
Member Author

lhoestq commented Jul 8, 2022

For the preview of BigBench datasets, we're just waiting for bigbench to have a stable version on PyPI, instead of the one hosted on GCS ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants