Drop Python 3.6 support #4460
Drop Python 3.6 support #4460
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
|
I've disabled the |
|
|
||
| @pytest.mark.skipif( | ||
| os.name == "nt" and (os.getenv("CIRCLECI") == "true" or os.getenv("GITHUB_ACTIONS") == "true"), | ||
| os.name in ["nt", "posix"] and (os.getenv("CIRCLECI") == "true" or os.getenv("GITHUB_ACTIONS") == "true"), |
There was a problem hiding this comment.
I don't think you need this ? The test currently passes on main on linux
There was a problem hiding this comment.
It doesn't on Python 3.7. Notice the test_dummy_dataset_serialize_s3 failure in one of the previous test
There was a problem hiding this comment.
Ok. This test is almost never run then, Maybe let's remove it completely in another PR, and make another one to make sure S3 export works as expected. Maybe we can use the mockfs fixture defined in #4724 instead
There was a problem hiding this comment.
This issue seems related to getmoto/moto#4750, but neither bumping moto to 3.0.0 (CI runs forever) nor pinning responses to 0.16 (the serialization fails) helps, so I agree we can disable these tests for now and replace them in another PR with the mockfs fixture
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Thanks :) not sure why torchaudio fails to decode/resample in the CI though (it uses the latest version 0.12.0)
|
This comment explains the issue with MP3 decoding in |
|
Yay for dropping Python 3.6! |
|
I think we can merge in this state. Also, if an env has Python version < 3.7 installed, we raise a warning, so I don't think we even need to create (and pin) an issue to notify the contributors of this change. |
Remove the fallback imports/checks in the code needed for Python 3.6 and update the requirements/CI files. Also, use Python types for the NumPy dtype wherever possible to avoid deprecation warnings in newer NumPy versions.