Adding dataset enwik8 #4321
Merged
Adding dataset enwik8 #4321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoestq
reviewed
May 31, 2022
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Cool thanks for adding this dataset :)
Before merging it would be nice to include some dummy data for the dataset to be tested properly.
Here are a few steps to create them:
- create a directory
datasets/enwik8/dummy/enwik8/1.1.0/dummy_data - inside the directory, create another dir
enwik8.zip(yes, a directory, not an actual ZIP archive) - inside
enwik8.zip, place two or three .raw files - zip the
dummy_datafolder todatasets/enwik8/dummy/enwik8/1.1.0/dummy_data.zip
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Contributor
Author
|
@lhoestq Thank you for the great feedback! Looks like all tests are passing now :) |
|
The documentation is not available anymore as the PR was closed or merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because I regularly work with enwik8, I would like to contribute the dataset loader 🤗